[MacPorts] #7756: Selfupdate rsync shouldn't specify complete path

[MacPorts]

#7756: Selfupdate rsync shouldn't specify complete path
----------------------+--------------------------------
  Reporter:  dluke@…  |      Owner:  macports-tickets@…
      Type:  defect   |     Status:  closed
  Priority:  Normal   |  Milestone:
 Component:  base     |    Version:  1.2
Resolution:  fixed    |   Keywords:
      Port:           |
----------------------+--------------------------------
Description changed by ryandesign@…:

Old description:

> selfupdate (like sync) should just run 'rsync' so that port's binpath is
> respected.
>
> Small diff inline:
>
> Index: darwinports.tcl
> ===================================================================
> RCS file:
> /Volumes/src/cvs/od/proj/darwinports/base/src/darwinports1.0/darwinports.tcl,v
> retrieving revision 1.206
> diff -u -r1.206 darwinports.tcl
> --- darwinports.tcl     16 Jan 2006 04:39:11 -0000      1.206
> +++ darwinports.tcl     13 Mar 2006 20:58:02 -0000
> @@ -1359,7 +1359,7 @@
>         ui_msg "DarwinPorts base version $dp_version_old installed"
>
>         ui_debug "Updating using rsync"
> -       if { [catch { system "/usr/bin/rsync $rsync_options
> rsync://${rsync_server}/${rsync_dir} $dp_base_path" } ] } {
> +       if { [catch { system "rsync $rsync_options
> rsync://${rsync_server}/${rsync_dir} $dp_base_path" } ] } {
>                 return -code error "Error: rsync failed in selfupdate"
>         }

New description:

 selfupdate (like sync) should just run 'rsync' so that port's binpath is
 respected.

 Small diff inline:

 {{{
 Index: darwinports.tcl
 ===================================================================
 RCS file:
 /Volumes/src/cvs/od/proj/darwinports/base/src/darwinports1.0/darwinports.tcl,v
 retrieving revision 1.206
 diff -u -r1.206 darwinports.tcl
 --- darwinports.tcl     16 Jan 2006 04:39:11 -0000      1.206
 +++ darwinports.tcl     13 Mar 2006 20:58:02 -0000
 @@ -1359,7 +1359,7 @@
         ui_msg "DarwinPorts base version $dp_version_old installed"

         ui_debug "Updating using rsync"
 -       if { [catch { system "/usr/bin/rsync $rsync_options
 rsync://${rsync_server}/${rsync_dir} $dp_base_path" } ] } {
 +       if { [catch { system "rsync $rsync_options
 rsync://${rsync_server}/${rsync_dir} $dp_base_path" } ] } {
                 return -code error "Error: rsync failed in selfupdate"
         }
 }}}

--

-- 
Ticket URL: <https://trac.macports.org/ticket/7756#comment:2>
MacPorts <https://www.macports.org/>
Ports system for OS X