[MacPorts] #725: UPDATE apache-ant-1.5.3-1

[MacPorts]

#725: UPDATE apache-ant-1.5.3-1
-------------------------+--------------------
  Reporter:  pguyot@…    |      Owner:  sean@…
      Type:  defect      |     Status:  closed
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  1.0
Resolution:  fixed       |   Keywords:
      Port:  apache-ant  |
-------------------------+--------------------
Changes (by ryandesign@…):

 * port:   => apache-ant


Old description:

> Apparently a bug made its way in latest attachment here:
>
> http://www.opendarwin.org/bugzilla/show_bug.cgi?id=357
>
> -       system "ln -fs ${path}${name}/bin/ant
> ${destroot}${prefix}/bin/ant"
> +    system "cd ${destroot} &&
> +        ln -fs ${prefix}/java/${name}/bin/ant ${prefix}/bin/ant"
>
> ${prefix} is /opt/local/ (well, usually), so this will end up making a
> link in
> /opt/local/bin/ in spite of the cd ${destroot}. So the symlink won't be
> registered as part of the port and won't be included in a package.
>
> Instead, I suggest doing the following:
>
> --- Portfile.old        Wed Jul 23 07:03:36 2003
> +++ Portfile    Wed Jul 23 07:38:51 2003
> @@ -35,8 +35,7 @@
>         system "cd ${worksrcpath}; cp -R ${name} ${path}"
>         system "rm ${path}${name}/bin/*.bat"
>      system "chmod -R ugo+r ${path}${name}"
> -       system "cd ${destroot} &&
> -       ln -fs ${prefix}/java/${name}/bin/ant ${prefix}/bin/ant"
> +       system "ln -fs {prefix}/java/${name}/bin/ant
> ${destroot}${prefix}/bin/ant"
>  }
>
>  variant darwin {
>
> but maybe the original line is more coherent with the usual policy
> regarding
> symlinks, i.e. to make them relative and not absolute.

New description:

 Apparently a bug made its way in latest attachment here:

 #357

 {{{
 -       system "ln -fs ${path}${name}/bin/ant
 ${destroot}${prefix}/bin/ant"
 +    system "cd ${destroot} &&
 +        ln -fs ${prefix}/java/${name}/bin/ant ${prefix}/bin/ant"
 }}}

 ${prefix} is /opt/local/ (well, usually), so this will end up making a
 link in
 /opt/local/bin/ in spite of the cd ${destroot}. So the symlink won't be
 registered as part of the port and won't be included in a package.

 Instead, I suggest doing the following:

 {{{
 --- Portfile.old        Wed Jul 23 07:03:36 2003
 +++ Portfile    Wed Jul 23 07:38:51 2003
 @@ -35,8 +35,7 @@
         system "cd ${worksrcpath}; cp -R ${name} ${path}"
         system "rm ${path}${name}/bin/*.bat"
      system "chmod -R ugo+r ${path}${name}"
 -       system "cd ${destroot} &&
 -       ln -fs ${prefix}/java/${name}/bin/ant ${prefix}/bin/ant"
 +       system "ln -fs {prefix}/java/${name}/bin/ant
 ${destroot}${prefix}/bin/ant"
  }

  variant darwin {
 }}}

 but maybe the original line is more coherent with the usual policy
 regarding
 symlinks, i.e. to make them relative and not absolute.

--

-- 
Ticket URL: <https://trac.macports.org/ticket/725#comment:6>
MacPorts <https://www.macports.org/>
Ports system for OS X