[MacPorts] #50697: VLC @2.2.2: build fails when using recently released ffmpeg-3.0

[MacPorts]

#50697: VLC @2.2.2: build fails when using recently released ffmpeg-3.0
----------------------------+-------------------------
  Reporter:  devans@…       |      Owner:  rjvbertin@…
      Type:  defect         |     Status:  new
  Priority:  Normal         |  Milestone:
 Component:  ports          |    Version:
Resolution:                 |   Keywords:
      Port:  VLC VLC-devel  |
----------------------------+-------------------------

Comment (by devans@…):

 Replying to [comment:20 rjvbertin@…]:
 > Well, this was less work and I had a bit more time than I thought . An
 initial "works-for-me" draft is available at
 >
 > https://github.com/RJVB/macstrop/tree/master/multimedia/VLC
 >
 > Could I ask you to have a look at the ffmpeg-VLC dependency list to see
 if it can be pruned a bit more?

 Yes, I think it can be.  ffmpeg is designed to build the base
 functionality without using any external libs at all and functionality
 based on external libs is disabled by default in general and must be
 explicitly enabled if desired.

 The VLC contrib build of ffmpeg only enables the following:
  * lame
  * openjpeg
  * libgsm
  * libvpx

 Your configuration seems to be consistent with this (less libgsm) but
 there are extra dependencies that are probably not doing any good since
 they're not enabled.  You should remove the following dependencies:
 {{{
                     port:libvorbis \
                     port:libopus \
                     port:libogg \
                     port:libtheora \
                     port:libass \

 }}}

 Also the following additional configuration items and corresponding
 dependencies


 {{{
                     --enable-libx264 \
                     --enable-libxvid
 depends_lib-append  port:XviD \
                     port:x264

 }}}

 Most of these are supported directly by VLC without using ffmpeg

 >
 > Two bits of collateral damage:
 > - I had to drop opencv support, as opencv depends on ffmpeg and that
 would probably cause runtime issues (in addition to linker errors)

 To avoid any linking issues/conflicts I would do as VLC does in the
 contrib build and build static libraries only.
 {{{
 --disable-shared --enable-static
 }}}


 > - I didn't manage to tell the linker to use the libraries in
 ${prefix}/lib/vlc/ffmpeg/lib rather than in ${prefix}/lib . The pkg-config
 file is set up correctly though, so I guess the only solution would be to
 patch the build system to use absolute paths rather than `-lfoo`
 arguments. A bit over the top, I've simply registered a build conflict.

 Did you try appending -L${prefix}/lib/vlc/ffmpeg/lib to LDFLAGS?

-- 
Ticket URL: <https://trac.macports.org/ticket/50697#comment:21>
MacPorts <https://www.macports.org/>
Ports system for OS X