[MacPorts] #51437: Should qscintilla force C++ linkage?

[MacPorts]

#51437: Should qscintilla force C++ linkage?
-------------------------+-------------------------
  Reporter:  mcalhoun@…  |      Owner:  michaelld@…
      Type:  defect      |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.3.4
Resolution:              |   Keywords:
      Port:  qscintilla  |
-------------------------+-------------------------
Description changed by ryandesign@…:

Old description:

> Many of the header files force C++ linkages QScintilla but only on Macs
> {{{
> #ifdef __APPLE__
> extern "C++" {
> #endif
> }}}
>
> This causes a problems when trying to build octave with GCC:
> * [https://trac.macports.org/ticket/51399 MacPorts Bug Report]
> * [http://savannah.gnu.org/bugs/?43243 Octave Bug Report]
> * [http://octave.1599824.n4.nabble.com/build-failure-on-
> OSX-10-9-td4659114.html Octave Mailing LIst]
> * [http://octave.1599824.n4.nabble.com/Building-3-8-0-on-Mountain-
> Lion-10-8-5-td4660795.html Octave Mailing List Again]
>
> Why forced C++ linkage is needed (but only on Macs) is not clear to
> me.[[BR]]
> I have posted a question on the
> [https://www.riverbankcomputing.com/pipermail/qscintilla/2016-May/001129.html
> upstream mailing list], but so far, no response.
>
> I have attached a patch that seems to fix the problem, but it seems a
> little dangerous without knowing why it was done in the first place.

New description:

 Many of the header files force C++ linkages QScintilla but only on Macs
 {{{
 #ifdef __APPLE__
 extern "C++" {
 #endif
 }}}

 This causes a problems when trying to build octave with GCC:
 * [ticket:51399 MacPorts Bug Report]
 * [http://savannah.gnu.org/bugs/?43243 Octave Bug Report]
 * [http://octave.1599824.n4.nabble.com/build-failure-on-
 OSX-10-9-td4659114.html Octave Mailing LIst]
 * [http://octave.1599824.n4.nabble.com/Building-3-8-0-on-Mountain-
 Lion-10-8-5-td4660795.html Octave Mailing List Again]

 Why forced C++ linkage is needed (but only on Macs) is not clear to
 me.[[BR]]
 I have posted a question on the
 [https://www.riverbankcomputing.com/pipermail/qscintilla/2016-May/001129.html
 upstream mailing list], but so far, no response.

 I have attached a patch that seems to fix the problem, but it seems a
 little dangerous without knowing why it was done in the first place.

--

-- 
Ticket URL: <https://trac.macports.org/ticket/51437#comment:1>
MacPorts <https://www.macports.org/>
Ports system for OS X