[MacPorts] #52870: shairport-sync @2.8.6_0: submission

[MacPorts]

#52870: shairport-sync @2.8.6_0: submission
-----------------------------+--------------------------------
  Reporter:  ale275          |      Owner:  macports-tickets@…
      Type:  submission      |     Status:  new
  Priority:  Normal          |  Milestone:
 Component:  ports           |    Version:  2.3.4
Resolution:                  |   Keywords:
      Port:  shairport-sync  |
-----------------------------+--------------------------------

Comment (by neverpanic):

 A couple of comments:

 - For ports from GitHub, use `PortGroup github 1.0` and call
 `github.setup`. In your case, the correct line would be `github.setup
 mikebrady shairport-sync 2.8.6`. That automatically sets version,
 homepage, fetch.type, git.url and git.branch properly, so you should
 remove those. It also automatically uses a tarball download, which allows
 better caching on our mirror infrastructure.
 - The maintainer field does not (yet) accept GitHub usernames, so make
 this an email address of yours in the obfuscated `domain.tld:localpart`
 format. Putting `ale275` there will make MacPorts think your email address
 is `ale275 at macports.org`.
 - Please decide whether you want to mark the port with the
 `openmaintainer` policy; see https://guide.macports.org/#project.update-
 policies.nonmaintainer for an explanation. We don't mind either way, but
 want it to be a conscious decision, not a silent default.
 - Dependencies on openssl should be written
 `path:lib/libssl.dylib:openssl` so that libressl can satisfy them, unless
 you know the port won't build with libressl.
 - `configure.pre_args` already contains `--prefix=${prefix}`, so can just
 remove it from `configure.args`.
 - We are trying to get rid of `no_*` variants and instead prefer positive
 variants that are enabled by default, e.g.
   {{{
 variant metadata description {Enable metadata output} {
   configure.args-append --with-metadata
 }
 default_variants +metadata
   }}}

--
Ticket URL: <https://trac.macports.org/ticket/52870#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS