[MacPorts] #52898: revision convenience
MacPorts
noreply at macports.org
Thu Nov 17 09:53:44 CET 2016
#52898: revision convenience
--------------------------+--------------------------------
Reporter: RJVB | Owner: macports-tickets@…
Type: enhancement | Status: new
Priority: Low | Milestone:
Component: base | Version:
Resolution: | Keywords:
Port: |
--------------------------+--------------------------------
Comment (by RJVB):
Replying to [comment:7 raimue]:
> `port lint` warns when you hardcode the version number instead of using
`${version}`. I just noticed it only does this with `--nitpick`.
Indeed, but it rightly puts 'seems to' in the message.
> My proposed idea was to have the information on the same line. No, this
would not help in this case. I still had not understood your problem. Such
complex Portfiles should also not be the usual case.
True, and I'd hope my kind of sloppiness is also not the usual case
(though I'm less certain there :)).
Does Tcl allow putting the info on the same line without actual
modification of the syntax? Something like
{{{
version x.y ; revision N
}}}
would read almost the same as your proposition and make it less likely to
forget removing a revision.
> Assuming such a script is run in the git repository (or against the
original Portfile), it could run this check for all subports.
Yes, I assume it could be as complex as needed, but then we'd almost have
to consider interfacing it to base somehow, a Tcl script that includes the
relevant libraries so it can do actual Portfile parsing. There's an
additional detail that wasn't really relevant until now: KDE releases
their frameworks, applications and "plasma" stuff in bundles, so it makes
sense to declare the current version in the PortGroup. That means you need
to parse the whole Portfile in order to know the version number.
I suppose one could add a check to `port lint`, where it compares the
current newest installed version with the version provided by the port,
but how often does one lint a port for just a simple version upgrade?
All in all this is beginning to look like killing a gnat with a Stinger
missile ;)
--
Ticket URL: <https://trac.macports.org/ticket/52898#comment:8>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list