[MacPorts] #52511: mc: subshell not working with /bin/sh

[MacPorts]

#52511: mc: subshell not working with /bin/sh
-----------------------+--------------------
  Reporter:  sierkb@…  |      Owner:  mkae
      Type:  defect    |     Status:  closed
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:
Resolution:  fixed     |   Keywords:
      Port:  mc        |
-----------------------+--------------------

Comment (by sierkb):

 Replying to [comment:10 mkae]:
 > So, I've built and ran a patched {{{mc}}} on Sierra (and for reference
 also on Mavericks) w/o seeing the above issue anymore.
 >
 > Done in r154272! (Let's hope that the buildbots will be fine with it!)

 OK. Thanks a lot. It works for me. But this tiny patch used by you has a
 disadvantage (delay of 5 or 10 seconds), as also mentioned in [https://www
 .midnight-commander.org/ticket/3658#comment:1 mc Ticket #3658 comment 1]:

   ''The attached patch allows mc to start without error. However, there is
 a 5 second delay when it starts. When trying to use the subshell, it
 simply shows a blank terminal, at which point any key press returns you to
 the normal mc file layout screen.''

 I guess, there seems to be a better and more sophisticated upstream patch
 around (hint: this mc upstream comment [https://www.midnight-
 commander.org/ticket/3689#comment:11 mc doesn't recognize shell (e.g.,
 /bin/sh) as bash when it is a link to bash binary, comment 11]), which
 avoids such delays and other things:

 '''[https://www.midnight-commander.org/ticket/3692 mc Ticket #3692 More
 sophisticated shell type detection method]'''

 Maybe prefer this more sophisticated mc ticket 3692 patch over the quick
 fix mc ticket 3658 patch used by you?

 [[br]]
 > Yet, I don't know what to make of the [https://www.midnight-
 commander.org/ticket/3658#comment:6 patch source's comment:6]...

 See below.

 >Well, it's solved for MacPorts now.

 See above.

 > If they don't want to commit this patch they'll surely figure out
 another solution.

 Maybe they prefer this mentioned [https://www.midnight-
 commander.org/ticket/3692 mc Ticket #3692 More sophisticated shell type
 detection method] (which is targeted: ''Future Releases'', that's why I
 asked them to ship it more early rather than in any so far unnamend future
 release)?

--
Ticket URL: <https://trac.macports.org/ticket/52511#comment:11>
MacPorts <https://www.macports.org/>
Ports system for OS X