[MacPorts] #52385: hexchat: build failure on <10.10

[MacPorts]

#52385: hexchat: build failure on <10.10
----------------------+----------------------
  Reporter:  ionic@…  |      Owner:  raimue@…
      Type:  defect   |     Status:  closed
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:  fixed    |   Keywords:
      Port:  hexchat  |
----------------------+----------------------

Comment (by ken.cunningham.webuse@…):

 Hi ,

 The patch gets applied, but unfortunately doesn't fix the build on 10.6.
 It appears that the availability guard is not working correctly on this
 system at least.

 {{{
 :info:build /bin/sh ../../libtool  --tag=CC   --mode=compile
 /opt/local/bin/clang-mp-3.7 -DHAVE_CONFIG_H -I. -I../..
 -I../../src/common -I./shared  -D_REENTRANT -I/opt/local/include/glib-2.0
 -I/opt/local/lib/glib-2.0/include -I/opt/local/include
 -I/opt/local/include  -pipe -Os -arch x86_64 -funsigned-char -fstack-
 protector-strong -fPIE -fPIC -Wall -Wextra -Wstrict-prototypes -Wno-
 unused-parameter -Wno-sign-compare -Wno-pointer-sign -Wno-missing-field-
 initializers -Wno-unused-result -Werror=format-security -Werror=init-self
 -Werror=declaration-after-statement -Werror=missing-include-dirs -Werror
 =date-time -Werror=implicit-function-declaration -Werror=pointer-arith -c
 -o shared/df.lo shared/df.c
 :info:build /bin/sh ../../libtool    --mode=compile /opt/local/bin/clang-
 mp-3.7 -DHAVE_CONFIG_H -I. -I../..  -I../../src/common -I./shared
 -D_REENTRANT -I/opt/local/include/glib-2.0
 -I/opt/local/lib/glib-2.0/include -I/opt/local/include
 -I/opt/local/include  -pipe -Os -arch x86_64 -c -o osx/backend.lo
 osx/backend.m
 :info:build libtool: compile:  /opt/local/bin/clang-mp-3.7 -DHAVE_CONFIG_H
 -I. -I../.. -I../../src/common -I./shared -D_REENTRANT
 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include
 -I/opt/local/include -I/opt/local/include -pipe -Os -arch x86_64 -c
 osx/backend.m  -fno-common -DPIC -o osx/.libs/backend.o
 :info:build libtool: compile:  /opt/local/bin/clang-mp-3.7 -DHAVE_CONFIG_H
 -I. -I../.. -I../../src/common -I./shared -D_REENTRANT
 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include
 -I/opt/local/include -I/opt/local/include -pipe -Os -arch x86_64
 -funsigned-char -fstack-protector-strong -fPIC -Wall -Wextra -Wstrict-
 prototypes -Wno-unused-parameter -Wno-sign-compare -Wno-pointer-sign -Wno-
 missing-field-initializers -Wno-unused-result -Werror=format-security
 -Werror=init-self -Werror=declaration-after-statement -Werror=missing-
 include-dirs -Werror=date-time -Werror=implicit-function-declaration
 -Werror=pointer-arith -c shared/df.c  -fno-common -DPIC -o
 shared/.libs/df.o
 :info:build osx/backend.m:93:2: error: use of undeclared identifier
 'NSOperatingSystemVersion'; did you mean 'kNSLMinSystemVersion'?
 :info:build         NSOperatingSystemVersion version = [info
 operatingSystemVersion];
 :info:build         ^~~~~~~~~~~~~~~~~~~~~~~~
 :info:build         kNSLMinSystemVersion
 }}}

 the patch is applied, tho

 {{{

 static char *
 get_os_fallback (void)
 {
 #if MAC_OS_X_VERSION_MIN_REQUIRED <= MAC_OS_X_VERSION_10_9
         SInt32 ver_major = 0,
                ver_minor = 0,
                ver_patch = 0;

         Gestalt (gestaltSystemVersionMajor, &ver_major);
         Gestalt (gestaltSystemVersionMinor, &ver_minor);
         Gestalt (gestaltSystemVersionBugFix, &ver_patch);

         return g_strdup_printf ("OS X %d.%d.%d", ver_major, ver_minor,
 ver_patch);
 #else
         NSProcessInfo *info = [NSProcessInfo processInfo];
         NSOperatingSystemVersion version = [info operatingSystemVersion];

         return g_strdup_printf ("OS X %ld.%ld.%ld", version.majorVersion,
 version.minorVersion, version.patchVersion);
 #endif
 }
 }}}

 However, changing the test line to this version works OK:
 {{{

 #if MAC_OS_X_VERSION_MAX_AVAILABLE <= MAC_OS_X_VERSION_10_9
 }}}

 {{{

 KensMacBookPro:hexchat-2.12.1 cunningh$ sudo port upgrade hexchat--->
 Computing dependencies for hexchat
 --->  Building hexchat
 --->  Staging hexchat into destroot
 --->  Installing hexchat @2.12.1_0+quartz+ssl
 --->  Cleaning hexchat
 --->  Computing dependencies for hexchat
 --->  Deactivating hexchat @2.10.2_2+quartz+ssl
 --->  Cleaning hexchat
 --->  Activating hexchat @2.12.1_0+quartz+ssl
 --->  Cleaning hexchat
 --->  Updating database of binaries
 }}}

-- 
Ticket URL: <https://trac.macports.org/ticket/52385#comment:10>
MacPorts <https://www.macports.org/>
Ports system for the Mac operating system