[MacPorts] #53911: gtk3 at 3.22.11_0: fails to build with glib2-devel at 2.52.0_0

[MacPorts]

#53911: gtk3 at 3.22.11_0: fails to build with glib2-devel at 2.52.0_0
---------------------+---------------------
  Reporter:  Ionic   |      Owner:  dbevans
      Type:  defect  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:
      Port:  gtk3    |
---------------------+---------------------

Comment (by Ionic):

 Ryan, please review that patch.

 I had to go to some length to make sure that I do not overwrite the
 changes you did for building universally (which, I may add, should really
 better be part of the autoconf/automake files instead of a generated
 configure script...)

 Essentially, I implemented the changes in autoconf.ac and Makefile.am,
 then had autotools re-generate the affected files (config.h.in, configure,
 Makefile.in) and spun that off in a different patchfile that can be
 applied without having to use autoreconf.

 I have also added x11 and quartz variants to glib. They do not really do
 anything X11- or Quartz-related per se, but switch to the generic
 (freedesktop-based) appinfo implementation for X11 builds and stick to the
 native (appbundle-based) implementation for Quartz builds. Needless to
 say, either maintainers or users have to make sure that `gtk3` and
 `glib2-devel` are built with the same variants, but I think that's fine.

 Regarding `gtk3`, I'm only using the mentioned upstream patch for +quartz
 builds. This is because we actually *want* to use the freedesktop-based
 implementation for +x11 builds. This also means that we will have to work
 with upstream to make sure that once that patch is part of a new official
 GTK+ release, switching between these implementations is possible at build
 time.


 I will make sure to work with upstream to include the glib2 patch as soon
 as possible, so that we're not burdened by maintaining it for a prolonged
 time.


 With these changes, `gtk3` builds fine with `glib2-devel` for me now, all
 X11-based. I have tested a Quartz-Build of `glib2-devel` (but not `gtk3`
 because that would have required to rebuild "everything") and it also
 works as intended - baking in the `gosxappinfo` implementation into
 `libgio-2.0`.

--
Ticket URL: <https://trac.macports.org/ticket/53911#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS