[MacPorts] #53929: qemu @ 2.8.0 +curses: configure fails to find ncurses

[MacPorts]

#53929: qemu @ 2.8.0 +curses: configure fails to find ncurses
----------------------------+------------------
 Reporter:  stevecheckoway  |      Owner:
     Type:  defect          |     Status:  new
 Priority:  Normal          |  Milestone:
Component:  ports           |    Version:
 Keywords:  haspatch        |       Port:  qemu
----------------------------+------------------
 Configuring qemu fails with the +curses variant.

 {{{
 Executing:  cd
 "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_qemu/qemu/work/qemu-2.8.0"
 && ./configure --prefix=/opt/local --cpu=x86_64 --cc=/usr/bin/clang
 --objcc=/usr/bin/clang --host-cc=/usr/bin/clang
 --python=/opt/local/bin/python2.7 --iasl=/usr/bin/false --disable-cocoa
 --enable-curses --disable-sdl --disable-gtk --disable-opengl --enable-curl
 --enable-uuid --enable-vhdx --with-system-pixman --disable-attr --disable-
 vde --disable-brlapi --disable-bluez --disable-cap-ng --disable-spice
 --disable-libiscsi --disable-rbd --disable-smartcard --enable-libusb
 --disable-usb-redir --disable-seccomp --disable-glusterfs --disable-rdma
 --disable-libssh2 --disable-vnc --target-list=,i386-softmmu,x86_64-softmmu
 DEBUG: system:  cd
 "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_emulators_qemu/qemu/work/qemu-2.8.0"
 && ./configure --prefix=/opt/local --cpu=x86_64 --cc=/usr/bin/clang
 --objcc=/usr/bin/clang --host-cc=/usr/bin/clang
 --python=/opt/local/bin/python2.7 --iasl=/usr/bin/false --disable-cocoa
 --enable-curses --disable-sdl --disable-gtk --disable-opengl --enable-curl
 --enable-uuid --enable-vhdx --with-system-pixman --disable-attr --disable-
 vde --disable-brlapi --disable-bluez --disable-cap-ng --disable-spice
 --disable-libiscsi --disable-rbd --disable-smartcard --enable-libusb
 --disable-usb-redir --disable-seccomp --disable-glusterfs --disable-rdma
 --disable-libssh2 --disable-vnc --target-list=,i386-softmmu,x86_64-softmmu
 ./configure: --enable-uuid is obsolete, UUID support is always built
 ./configure: --enable-vhdx is obsolete, VHDX driver is always built

 ERROR: User requested feature curses
        configure was not able to find it.
        Install ncurses devel
 }}}

 Configuring (and building/installing) works correctly without +curses.

 The issue is that qemu wants wide character support but curses.h will only
 enable wide character support in a limited number of cases:

 {{{
 /*
  * With XPG4, you must define _XOPEN_SOURCE_EXTENDED, it is redundant (or
  * conflicting) when _XOPEN_SOURCE is 500 or greater.  If NCURSES_WIDECHAR
 is
  * not already defined, e.g., if the platform relies upon nonstandard
 feature
  * test macros, define it at this point if the standard feature test
 macros
  * indicate that it should be defined.
  */
 #ifndef NCURSES_WIDECHAR
 #if defined(_XOPEN_SOURCE_EXTENDED) || (defined(_XOPEN_SOURCE) &&
 (_XOPEN_SOURCE - 0 >= 500))
 #define NCURSES_WIDECHAR 1
 #else
 #define NCURSES_WIDECHAR 0
 #endif
 #endif /* NCURSES_WIDECHAR */
 }}}

 Of the options, it seems safer to define NCURSES_WIDECHAR=1 by passing
 --extra-cflags=-DNCURSES_WIDECHAR=1 to configure for the +curses variant.

 With the patch applied, the +curses variant builds and runs correctly (as
 far as I can tell from minimal testing).

--
Ticket URL: <https://trac.macports.org/ticket/53929>
MacPorts <https://www.macports.org/>
Ports system for macOS