[MacPorts] #54573: New port for Fricas (a Computer Algebra System)

[MacPorts]

#54573: New port for Fricas (a Computer Algebra System)
-------------------------+-----------------
  Reporter:  pietvo      |      Owner:
      Type:  submission  |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:
Resolution:              |   Keywords:
      Port:  fricas      |
-------------------------+-----------------

Comment (by ryandesign):

 Thanks. Some comments:

 * If the GitHub handle and the obfuscated email address in the
 `maintainers` line represent the same person, they should be grouped in
 curly braces (`{``}`).
 * `supported_archs` is a normal MacPorts "option", and as such the values
 are separated by whitespace; there should not be a comma.
 * `license` is also a normal "option", so MacPorts thinks this port is
 under three licenses, called "Modified", "BSD", and "license", which isn't
 what you wanted. If the software's license is sufficiently close to BSD,
 particularly with regard to distributability, then just put "BSD",
 otherwise just put "Permissive". If desired, you can clarify the license
 in a comment line above the `license` line.
 * Usually, we want rmd160 and sha256 checksums listed. Additional checksum
 types may be added to those if upstream publishes them.
 * `configure.cmd` and `build.cmd` should usually only be the actual
 command to run. The directory in which they should run should be set
 instead in `configure.dir` and `build.dir`. If you need to create the
 build directory, do so in a `pre-configure` block. If you need to set
 build args like setting the `MAYBE_VIEWPOINT` variable, use `build.args`.
 * The x11 variant should not depend on xorg. Nothing should; the xorg port
 is a convenience port enabling the user to install all of X at once. Ports
 should instead depend on the specific ports providing the specific
 libraries needed. You wrote the xorg dependency on the libX11 library.
 That library is in fact provided by the xorg-libX11 port, so you should
 depend on `port:xorg-libX11`, not `lib:libX11.6:xorg`. Note that you
 should not use a `lib:`-style dependency because that would allow software
 that wasn't installed with MacPorts to satisfy the dependency, which is
 not usually what we want.
 * It would be clearer if the code relating to the sbcl variant were
 contained within the sbcl variant. This would eliminate the need for each
 of the conflicting variants to remove the sbcl dependency and configure
 arg.
 * Similarly, it would be clearer if the post-patch code relating to the
 gmp variant were contained within the gmp variant.
 * The tabs should be converted to spaces and the whitespace fixed so that
 more of the portfile is neatly aligned into two columns.

--
Ticket URL: <https://trac.macports.org/ticket/54573#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS