[MacPorts] #47934: libvpx should be in depends_build not depends_lib

[MacPorts]

#47934: libvpx should be in depends_build not depends_lib
-------------------------------------------------+-------------------------
  Reporter:  ryandesign                          |      Owner:  ryandesign
      Type:  defect                              |     Status:  closed
  Priority:  Normal                              |  Milestone:
 Component:  ports                               |    Version:  2.3.3
Resolution:  fixed                               |   Keywords:
      Port:  avidemux, ffmpeg, ffmpeg-devel,     |
  gd2, gstreamer010-gst-plugins-bad, gstreamer1  |
  -gst-plugins-good                              |
-------------------------------------------------+-------------------------

Comment (by ryandesign):

 Replying to [comment:6 dstrubbe]:
 > I'm don't think this is a good idea for gd2, because it recommends
 linking libvpx according to its config binary:
 > {{{
 > $ gdlib-config --libs
 > -lgd -ljpeg -lz -L/opt/local/lib -lpng16 -L/opt/local/lib -lfreetype
 -L/opt/local/lib -lfontconfig -lfontconfig
 > -L/opt/local/lib -lXpm -L/opt/local/lib -lvpx -L/opt/local/lib -ltiff
 -liconv
 > }}}
 > Everything else in this list is depends_lib for gd2. As a result, a code
 which naturally uses the output of this command in a configure script to
 decide how to link will fail if libvpx is no longer installed.

 gd2 no longer uses libvpx as of 2.2.0; see
 https://github.com/libgd/libgd/issues/129.

 > On the other hand, the depends_lib port:expat does not seem to be
 dynamically linked into any library or executable from gd2, so I wonder if
 it really needs to be depends_lib.

 Looks like I added the expat dependency when updating the port to 2.0.34
 in 2007 in [2fb64674a09a9a070635c840110f4e208d0be078/macports-ports]. That
 was probably wrong. expat was probably only an indirect dependency through
 gettext. That was back when libraries were being overlinked to indirect
 dependencies.  Overlinking was fixed in MacPorts in 2013; see #38010 and
 [a940ce8fed8df056b8d5720ac69961a6e9c6ecf7/macports-base].

--
Ticket URL: <https://trac.macports.org/ticket/47934#comment:8>
MacPorts <https://www.macports.org/>
Ports system for macOS