[MacPorts] #53525: valgrind: doesn't build with an old clang

[MacPorts]

#53525: valgrind: doesn't build with an old clang
-----------------------+--------------------
  Reporter:  mojca     |      Owner:  raimue
      Type:  defect    |     Status:  new
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:
Resolution:            |   Keywords:  lion
      Port:  valgrind  |
-----------------------+--------------------

Comment (by mojca):

 Oh, wait. It was me who opened the ticket #49161 that was closed with "I
 believe this has been fixed upstream."
 I'm sorry, I checked the tickets, but I only checked for open ones.

 I'm not sure what your suggestion was about `sh -x ./configure`, but
 anyway, here's my analysis of `configure.ac`:

 {{{
 > /usr/bin/clang  --version
 Apple LLVM version 4.2 (clang-425.0.28) (based on LLVM 3.2svn)
 Target: x86_64-apple-darwin11.4.2
 Thread model: posix

 > /usr/bin/clang  --version | sed -n -e 's/.*\Apple \(LLVM\)
 version.*clang.*/\1/p'
 LLVM
 }}}

 So the first test is true and we get
 {{{
 is_clang="applellvm"
 }}}

 and
 {{{
 > /usr/bin/clang --version | sed -n -e 's/.*LLVM version
 \([0-9.]*\).*$/\1/p'
 4.2
 }}}
 so:
 {{{
 gcc_version=4.2
 }}}

 But then the test checks for
 {{{
 case "${is_clang}-${gcc_version}" in
      applellvm-5.1|applellvm-6.*|applellvm-7.*|applellvm-8.*)
 }}}
 and leaves `applellvm-4.2` out of the game. And Xcode version 9 will
 likely be affected as well :)

 The [[XcodeVersionInfo]] reveals the super complex Apple's naming scheme.

 If they need clang 2.9, then something between 1.7 and 2.1 should already
 satisfy this condition rather than just version 5.1 and up.

--
Ticket URL: <https://trac.macports.org/ticket/53525#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS