[MacPorts] #48807: python messes with terminal state on exit
MacPorts
noreply at macports.org
Wed Feb 22 17:28:07 UTC 2017
#48807: python messes with terminal state on exit
-------------------------------------------------+-------------------------
Reporter: yselivanov@… | Owner:
| jyrkiwahlstedt
Type: defect | Status: new
Priority: Normal | Milestone:
Component: ports | Version: 2.3.3
Resolution: | Keywords: haspatch
Port: python26 python27 python python34 |
python35 libedit |
-------------------------------------------------+-------------------------
Comment (by raimue):
Replying to [comment:111 eborisch]:
> Please confirm, and assuming you see the same results, we can try to
track down why having readline present -- even just during configure; you
can remove it between configure and the remainder of the install process
-- on the system makes this problem go away.
The existing patch-libedit.diff replaces `-lreadline` with `-ledit`, which
makes the check for readline to actually link with the readline
compatibility layer of libedit. However, there are other checks still
using `-lreadline` in the configure script.
@mohd-akram
Regarding the attached patch, these hunks in your patch look bogus:
{{{
#!patch
-#ifdef __APPLE__
+#ifndef __APPLE__
}}}
As I understand it, these #ifdef blocks were meant specifically for
libedit as provided by Apple on macOS. Negating the conditional does not
make sense to me, as that would mean they should be applied to all other
systems. Just for additional background, most of this was added as
[https://mail.python.org/pipermail/python-dev/2013-October/129832.html a
workaround] to detect a possible bug in libedit as distributed by Apple at
runtime. In order to eventually get such a fix upstream, the logic should
be precise. Or just delete the conditional code with the patch, but then
we will never get this upstream.
If you want to get rid of these blocks completely, the right thing would
be to add an additional configure check defining a macro indicating
whether it is using the broken Apple libedit or the fixed version from
MacPorts.
--
Ticket URL: <https://trac.macports.org/ticket/48807#comment:113>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list