[MacPorts] #53425: gedit-app

MacPorts noreply at macports.org
Mon Jan 30 01:09:20 UTC 2017


#53425: gedit-app
-------------------------+-----------------
  Reporter:  e-t-h-a-n   |      Owner:
      Type:  submission  |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:
Resolution:              |   Keywords:
      Port:  gedit-app   |
-------------------------+-----------------

Comment (by ryandesign):

 You're including the compiler_blacklist_versions portgroup, but aren't
 using it.

 You're setting `configure.cmd ./autogen.sh`, but aren't adding the build
 dependencies that script will need (autoconf, automake, gettext, gtk-doc,
 intltool, libtool, yelp-tools).

 Instead of `system "cd ${worksrcpath} && ..."`, please use `system -W
 ${worksrcpath} "..."`

 Instead of assuming the applications directory is /Applications/MacPorts,
 please use the variable `${applications_dir}`

 Instead of using `system` to copy the application, use the MacPorts Tcl
 `copy` procedure.

 There's no need to create the applications directory before copying to it;
 MacPorts creates it and other common destroot directories for you.

 Your patch includes a comment that reads "Apperentely Pango doesn't
 include modules anymore?" Yes, pango modules died with version 1.37.0.

 The build fails, saying:

 {{{
 --->  Building gedit-app
 DEBUG: Executing proc-pre-org.macports.build-build-0
 DEBUG: Executing org.macports.build (gedit-app)
 DEBUG: system: cd /opt/local/var/macports/build/_private_tmp_gnome_gedit-
 app/gedit-app/work/gedit-app-3.22.0 && MACPORTS_PREFIX="/opt/local" gtk-
 mac-bundler osx/bundle/data/gedit.bundle
 Cannot find source to copy: /opt/local/share/themes/Mac
 }}}

 It's better to just attach the text files to the ticket directly, rather
 than inside a tarball; it's easier to review that way.

--
Ticket URL: <https://trac.macports.org/ticket/53425#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list