[MacPorts] #52767: port lint should warn when modeline is missing
MacPorts
noreply at macports.org
Sat Jul 15 17:02:25 UTC 2017
#52767: port lint should warn when modeline is missing
--------------------------+--------------------------------
Reporter: ryandesign | Owner: macports-tickets@…
Type: enhancement | Status: new
Priority: Normal | Milestone:
Component: base | Version: 2.3.4
Resolution: | Keywords:
Port: |
--------------------------+--------------------------------
Comment (by jmroot):
r-
The patch in the PR warns in every case except where exactly the
recommended modeline is on the first line. The request here is to warn
only if the Portfile doesn't have a modeline. The existing variation in
modelines is valid because indentation style is up to the maintainer, and
because some maintainers use a custom Portfile syntax highlighting mode in
their editor and set the file type to Portfile in the modeline to enable
that.
The other thing that lint should complain about is if the actual
indentation doesn't match that declared in the modeline, but that might be
difficult.
--
Ticket URL: <https://trac.macports.org/ticket/52767#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list