[MacPorts] #54216: zlib +ng (and +cloudflare) accelerated variants
MacPorts
noreply at macports.org
Mon Jun 19 09:37:08 UTC 2017
#54216: zlib +ng (and +cloudflare) accelerated variants
--------------------------+------------------------
Reporter: RJVB | Owner: ryandesign
Type: enhancement | Status: assigned
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords: haspatch
Port: zlib |
--------------------------+------------------------
Comment (by RJVB):
In a sense they are indeed complete rewrites, and esp. for the CloudFlare
variant there is the issue that it has a lower version (which we could
spoof, of course).
If this had been a proper port of mine I would have (re)designed it with 3
sections, as if containing 3 subports instead of 3 build variants. The
reason I've gone with variants is that port:zlib is among the ports with
the largest number of dependents at all levels in the dependency graph.
It'd be too easy to break things with a single unhappy commit.
And variants make it easier for users to go back to the official version
for whatever reason.
FWIW, this is an example where a syntax of the type `provides foo` or
`alternative_for foo` would be useful.
It is stated in the summary that the +NG variant configures zlib-ng to be
ABI compliant (I have a PR out upstream for detail they let slip through
in that aspect). The CloudFlare patches have always aimed to be ABI
compliant but there too I have a PR out for the 32bit build. And yes,
they're API compliant too (as far as that doesn't follow from being ABI
compliant).
I have replaced my system libz.dylib with the CloudFlare variant at about
the time I filed this ticket, and haven't noticed any issues (on Mac and
Linux, btw).
Of course there's little interest in adding benchmark results to the final
portfile(s). Although ... 8-)
--
Ticket URL: <https://trac.macports.org/ticket/54216#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list