[MacPorts] #54086: mpbb: unrecognized option `--archive-site' Try `./mpbb/mpbb help' for more information.

MacPorts noreply at macports.org
Tue May 2 11:47:14 UTC 2017


#54086: mpbb: unrecognized option `--archive-site' Try `./mpbb/mpbb help' for more
information.
-----------------------------+---------------------
  Reporter:  ryandesign      |      Owner:  admin@…
      Type:  defect          |     Status:  new
  Priority:  Normal          |  Milestone:
 Component:  server/hosting  |    Version:
Resolution:                  |   Keywords:
      Port:                  |
-----------------------------+---------------------

Comment (by neverpanic):

 Here's my ad-hoc analysis from IRC, hoping that it helps. Don't have time
 to make the change right now, though.

 - mpbb is invoked as `./mpbb --archive-site foobar list-subports
 "portname"`
 - That hands over control flow to `mpbb-list-subports` in
 https://github.com/macports/mpbb/blob/master/mpbb#L116, passing all
 options using `"$@"`
 - `list-subports()` in `mpbb-list-subports` runs `for port in "$@"; do
 print-subports "$port"; done`, see
 https://github.com/macports/mpbb/blob/master/mpbb-list-subports#L109
 - And `print-subports()` runs `parseopt archive-site: "$@"`, which tries
 to find `--archive-site` in `"$@"` of that function, but that function
 only gets "portname" as argument, which does not contain `--archive-site`,
 obviously
 - So
 https://github.com/macports/mpbb/commit/5c7ba12259a066a90a3e2ca2e4b09c9bac4aeb7b
 is buggy, the `parseopt archive-site: "$@" || return` should have been in
 `list-subports()`
 - Additionally, I think https://github.com/macports/macports-
 infrastructure/commit/f79cc559611e5f42dd26808f38cd0750beee12bf should have
 added the `--archive-site` flag after `list-subports`, not before.

--
Ticket URL: <https://trac.macports.org/ticket/54086#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list