[MacPorts] #55303: postgresql92, postgresql93, postgresql94, postgresql95, postgresql96, postgresql10: universal variant fails

[MacPorts]

#55303: postgresql92, postgresql93, postgresql94, postgresql95, postgresql96,
postgresql10: universal variant fails
-------------------------------------------------+-------------------------
  Reporter:  ryandesign                          |      Owner:
      Type:  defect                              |     Status:  new
  Priority:  Normal                              |  Milestone:
 Component:  ports                               |    Version:
Resolution:                                      |   Keywords:
      Port:  postgresql92, postgresql93,         |
  postgresql94, postgresql95, postgresql96,      |
  postgresql10                                   |
-------------------------------------------------+-------------------------

Comment (by MarcusCalhoun-Lopez):

 I would humbly suggest that using the [https://github.com/macports
 /macports-ports/blob/master/_resources/port1.0/group/muniversal-1.0.tcl
 muniversal PortGroup] is the best long-term solution.[[BR]]
 This is exactly the kind of situation the PortGroup was designed for.

 Short-term, however, some changes would have to be made.[[BR]]
 So far, I have only had a chance to look at [https://github.com/macports
 /macports-ports/blob/master/databases/postgresql96/Portfile
 postgresql96].[[BR]]
 The main change is:
 * Do not manually [https://github.com/macports/macports-
 ports/blob/5d4f31a114b0a87fac7da49470a5303d46876caa/databases/postgresql96/Portfile#L109
 build] and [https://github.com/macports/macports-
 ports/blob/5d4f31a114b0a87fac7da49470a5303d46876caa/databases/postgresql96/Portfile#L115
 install] contrib files.
 * Instead, set {{{build.target}}} and {{{destroot.target}}} to {{{world}}}
 and {{{install-world}}} respectively.
 The use of the [https://github.com/macports/macports-
 ports/blob/5d4f31a114b0a87fac7da49470a5303d46876caa/databases/postgresql96/Portfile#L88
 contribs variable] is problematic in the first place.[[BR]]
 It is set in {{{post-build}}} and used in {{{post-destroot}}}.[[BR]]
 If the {{{build}}} and {{{destroot}}} phases are performed separately, I
 believe certain files would not be installed (with no error).

 Attached is my proposed solution for postgresql96.[[BR]]
 However, I do not relish the idea of modifying and testing all six ports
 (postgresql92, postgresql93, postgresql94, postgresql95, postgresql96, and
 postgresql10) or even the older ports (postgresql7, postgresql80,
 postgresql81, postgresql82, postgresql83, postgresql84, postgresql90, and
 postgresql91).[[BR]]

 Is there any way to mark some of these as obsolete?[[BR]]
 Ideally, there would only be one PostgreSQL port.[[BR]]
 I am not an expert on PostgreSQL, so I do not know if there are reasons
 for keeping so many versions around.[[BR]]
 Perhaps only support the latest two or three versions?[[BR]]
 Even limiting PostgreSQL to the
 [https://en.wikipedia.org/wiki/PostgreSQL#Release_history five versions]
 supported upstream would be helpful.

--
Ticket URL: <https://trac.macports.org/ticket/55303#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS