[MacPorts] #55418: gds @2.17.7_1: error: ordered comparison between pointer and zero (was: GDS fails to build on Sierra)

[MacPorts]

#55418: gds @2.17.7_1: error: ordered comparison between pointer and zero
---------------------+------------------------
  Reporter:  rxa254  |      Owner:  ed.maros@…
      Type:  defect  |     Status:  assigned
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:
      Port:  gds     |
---------------------+------------------------
Changes (by ryandesign):

 * status:  new => assigned
 * keywords:  gds PulsarMon =>
 * port:   => gds
 * owner:   => ed.maros@…


Comment:

 The log says:

 {{{
 :info:build PulsarMon.cc:264:14: error: ordered comparison between pointer
 and zero ('FILE *' (aka '__sFILE *') and 'int')
 :info:build             if (tmp < 0) perror("Unable to divert stderr");
 :info:build                 ~~~ ^ ~
 :info:build PulsarMon.cc:268:14: error: ordered comparison between pointer
 and zero ('FILE *' (aka '__sFILE *') and 'int')
 :info:build             if (tmp < 0) perror("Unable to divert stdout");
 :info:build                 ~~~ ^ ~
 :info:build 2 errors generated.
 }}}

 This is clearly a bug in the source. Nobody should ever check if a pointer
 is less than zero; that will never occur.

 A newer version of gds is available upstream. Maybe they've already fixed
 this problem. Ed, can you update the port?

 {{{
 $ port livecheck gds
 gds seems to have been updated (port version: 2.17.7, new version: 2.18.3)
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/55418#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS