[MacPorts] #55417: faac @1.29.9.2: error: use of undeclared identifier 'bit_SSE2'

[MacPorts]

#55417: faac @1.29.9.2: error: use of undeclared identifier 'bit_SSE2'
---------------------+------------------------
  Reporter:  RobK88  |      Owner:  ryandesign
      Type:  defect  |     Status:  closed
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:  2.4.2
Resolution:  fixed   |   Keywords:  lion
      Port:  faac    |
---------------------+------------------------

Comment (by kencu):

 OK, I know I"m going to get clobbered for this, but I respectfully
 disagree with that idea.

 There is some benefit to going through the process of blacklisting old
 compilers, I guess, but it comes at a substantial cost. It takes time to
 figure out where the line should be drawn, you have to do something about
 PPC (or not), and in the end you build with an old, clunky clang version
 (usually clang-3.4, which is ancient). And who wants to spend time
 debugging clang-3.4 build failures? And, the next time the port is
 updated, more than likely the compiler line will move up again.

 The cxx11 1.1 PortGroup forces a nice new clang-5.0, or on PPC, gcc6. It
 only changes the stdlib switch for c++, where it is almost certainly
 needed (for C11 it is ignored). How many ports are there that need C11,
 and use c++, but don't need c++11 (therefore could hit that narrow gap
 between the two standards, using C11 and still being able to use the old,
 non-c++11 libstdc++. I can't think of any.

 Most older systems will already have clang-5.0 installed anyway, as you
 need it to built half the software now (everything in the cxx11 1.1
 PortGroup). To me, it's a very easy win, win, win.

 Although I know it is not yet the party line for C11, honestly, I think it
 should be. IMHO, if the default compiler doesn't work, use the PortGroup,
 and you're done with that port and moving on to the next issue.

 Now I will duck.

--
Ticket URL: <https://trac.macports.org/ticket/55417#comment:12>
MacPorts <https://www.macports.org/>
Ports system for macOS