[MacPorts] #54215: gcc7, libgcc: broken on powerpc
MacPorts
noreply at macports.org
Thu Oct 5 03:06:20 UTC 2017
#54215: gcc7, libgcc: broken on powerpc
---------------------------+----------------------
Reporter: mojca | Owner: kencu
Type: defect | Status: closed
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: fixed | Keywords: haspatch
Port: gcc7, libgcc |
---------------------------+----------------------
Comment (by ccorn):
I have now analyzed the effects of the four patches proposed with
{{{patch-darwin-ppc-2017-01-msg02971.diff}}}.
* Patch 1/4 copies stack alignment changes previously applied to
{{{aix.h}}}.
This seems to cause 15 additional testsuite failures
involving {{{gcc/testsuite/gcc.dg/builtin-apply4.c}}} and
{{{gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-4.c}}}.
The failures are related to the builtins around
[https://gcc.gnu.org/onlinedocs/gcc/Constructing-Calls.html
{{{__builtin_apply}}}]
as defined in {{{gcc/builtins.c}}}.
I'd leave that patch out.
* Patch 2/4 turns out to be necessary and sufficient for the non-Ada
build to succeed. If you want a minimal patchset, stick to that one.
* Patch 3/4 seems reasonable (marking {{{longjmp noreturn}}}),
but does not contribute changes to the test summary.
* Patch 4/4 looks reasonable (selecting Darwin thread headers),
but is Ada-related, thus irrelevant here.
Attaching the {{{gcc7}}} testsuite log diff showing the removal of
alignment test failures when only patch 2 is used.
Therefore, I recommend to remove patch 1 and keep patch 2.
Patch 3 and patch 4 can be left to upstream judgement.
--
Ticket URL: <https://trac.macports.org/ticket/54215#comment:45>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list