[MacPorts] #55096: libphonenumber-cpp @8.8.3: should not fetch files in post-extract

[MacPorts]

#55096: libphonenumber-cpp @8.8.3: should not fetch files in post-extract
------------------------+--------------------------------
 Reporter:  ryandesign  |      Owner:  dbevans
     Type:  defect      |     Status:  new
 Priority:  Normal      |  Milestone:
Component:  ports       |    Version:
 Keywords:              |       Port:  libphonenumber-cpp
------------------------+--------------------------------
 libphonenumber-cpp should not fetch additional files in post-extract as it
 does here:

 {{{
 set gtest_version   1.7.0
 set gtest_dir       ${workpath}
 set gtest_archive   v${gtest_version}.zip
 set gtest_srcdir    ${gtest_dir}/gtest-${gtest_version}
 set gtest_url       https://github.com/neloe/gtest/archive

 post-extract {
     curl fetch ${gtest_url}/${gtest_archive} ${gtest_dir}/${gtest_archive}
     system "/usr/bin/unzip -d ${gtest_dir} ${gtest_dir}/${gtest_archive}"
 }
 }}}

 All fetching should happen in the fetch phase. Let MacPorts do it for you
 by adding the gtest distfile to the `distfiles` variable.

 Switch to a .tar.gz file so that MacPorts can extract it for you too,
 since the port's main distfile is a .tar.gz file, and also because .tar.gz
 files are smaller than .zip files.

 Shouldn't you be [https://github.com/google/googletest/releases getting
 gtest from the developers directly], rather than from some random person's
 GitHub repo?

--
Ticket URL: <https://trac.macports.org/ticket/55096>
MacPorts <https://www.macports.org/>
Ports system for macOS