[MacPorts] #56236: emacs-app @25.3: aclocal-1.15: command not found (was: emacs-app subport fails to build)

[MacPorts]

#56236: emacs-app @25.3: aclocal-1.15: command not found
---------------------------+----------------------
  Reporter:  emcrisostomo  |      Owner:  drkp
      Type:  defect        |     Status:  assigned
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:
Resolution:                |   Keywords:
      Port:  emacs-app     |
---------------------------+----------------------
Changes (by ryandesign):

 * owner:  (none) => drkp
 * status:  new => assigned


Comment:

 automake was recently updated to 1.16.1, which explains why aclocal-1.15
 no longer exists (aclocal-1.16 now exists, but apparently this port
 doesn't know to look for it).

 For me the real question is why this port is trying to run aclocal in the
 build phase at all. If aclocal needs to be run, it needs to happen in the
 configure phase, before the configure script is run.

 The reason appears to be that the patchfile patch-
 inline-25.1-20151017.diff (which is added by the inline variant, which is
 enabled by default) patches configure.ac. If this patch is going to be
 kept, then the port needs to run autogen.sh before the configure script.
 The emacs-devel and emacs-app-devel subports already do that in a pre-
 configure block, so that block would just need to be extended to the
 emacs-app subport. And the other patchfile patch-configure.diff, which
 currently patches configure, needs to be changed to patch configure.ac,
 because otherwise its changes are lost when autogen.sh runs autoreconf and
 regenerates configure.

 Even though the emacs port itself wouldn't necessarily need to run
 autoreconf, it would simplify the port and reduce confusion to have all of
 its subports do so, rather than having some subports maintain patchfiles
 for configure and other subports maintain patchfiles for configure.ac.

-- 
Ticket URL: <https://trac.macports.org/ticket/56236#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS