[MacPorts] #57751: qt4-mac: lots of errors trying to build with clang-7.0 (presumably related to defaulting to c++17 mode)

[MacPorts]

#57751: qt4-mac: lots of errors trying to build with clang-7.0 (presumably related
to defaulting to c++17 mode)
--------------------+-----------------------
 Reporter:  kencu   |      Owner:  michaelld
     Type:  defect  |     Status:  assigned
 Priority:  Normal  |  Milestone:
Component:  ports   |    Version:
 Keywords:          |       Port:  qt4-mac
--------------------+-----------------------
 there are chunks of qt4-mac that just don't build with clang-7.0.

 Not a lot of point attaching a log as it's whack-a-mole -- you fix some
 and find more.

 Some groups around the web have worked on this, and there are some fixes
 out there if interested. I'll attach the patches I had figured out until I
 ran across something I didn't know how to fix in the javascript core:
 {{{
 In file included from wtf/DateMath.cpp:79:
 In file included from runtime/JSObject.h:26:
 In file included from runtime/ArgList.h:25:
 In file included from interpreter/CallFrame.h:26:
 In file included from runtime/JSGlobalData.h:33:
 In file included from heap/Heap.h:27:
 In file included from heap/MarkStack.h:32:
 ./wtf/HashSet.h:191:16: error: no viable conversion from returned value of
 type 'pair<WTF::HashTable<void *, void *, WTF::IdentityExtractor<void *>,
 WTF::PtrHash<void *>, WTF::HashTraits<void *>, WTF::HashTraits<void *>
 >::iterator, [...]>' to function return type 'pair<WTF::HashSet<void *,
 WTF::PtrHash<void *>, WTF::HashTraits<void *> >::iterator, [...]>'
         return m_impl.add(value);
                ^~~~~~~~~~~~~~~~~
 }}}
 Or maybe I just ran out of steam.

 I think the best idea may be to force down the standard rather than fix
 all these compilation errors. I think I'm seeing it in clang-7.0 because
 it defaults to a higher standard.

-- 
Ticket URL: <https://trac.macports.org/ticket/57751>
MacPorts <https://www.macports.org/>
Ports system for macOS