[MacPorts] #42101: upgrading qpdf attempts to link with old library

[MacPorts]

#42101: upgrading qpdf attempts to link with old library
---------------------+------------------------
  Reporter:  gnw3    |      Owner:  ryandesign
      Type:  defect  |     Status:  accepted
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:  2.2.1
Resolution:          |   Keywords:
      Port:  qpdf    |
---------------------+------------------------
Changes (by ryandesign):

 * status:  new => accepted
 * owner:  macports-tickets@… => ryandesign


Comment:

 Replying to [ticket:42101 gnw3]:
 > There were similar reports for previous versions

 Yes.

 It was previously [comment:ticket:32095:7 reported to us] in 2012 against
 version 2.3.0. I [https://sourceforge.net/p/qpdf/bugs/17/ reported it to
 the developer] along with a [browser:macports-ports/textproc/qpdf/files
 /patch-FLAGS.diff at df685480b4c1b261c2c1474b0746cc4bf8040e5e fix] (for
 examples/build.mk, libtests/build.mk, make/libtool.mk, qpdf/build.mk, and
 zlib-flate/build.mk). After explaining my fix to the developer, he agreed
 and stated he had included our patch in version 3.0, so when the port was
 next [changeset: updated to version 3.0.2] our patch was removed.

 However, it turns out the developer had only
 [https://github.com/ryandesign/qpdf/commit/30dbf94f53a3fd9760242883bdc5bddbaa0c9f44
 applied part of my patch] (the part for make/libtool.mk), so the problem
 was not fully fixed.

 #37508, reported to us in 2013, may have been another instance of the
 problem; we did not analyze the problem.

 In October 2017 somebody else [https://github.com/qpdf/qpdf/issues/158
 reported the problem again] to the developer, who
 [https://github.com/qpdf/qpdf/commit/6299c64cf3351fb1935319378aed421e26ed2f90
 committed a fix] that was the same as another part of the fix that I had
 originally submitted (the part for examples/build.mk, libtests/build.mk,
 and qpdf/build.mk). This change was published in qpdf 7.1.0.

 In January 2018 somebody else [https://github.com/qpdf/qpdf/issues/176
 reported the problem again] to the developer, who
 [https://github.com/qpdf/qpdf/commit/95ba7125ffa4efd4022fd27ab61ff739b0864258
 committed a fix] that was the same as another part of the fix that I had
 originally submitted (the part for libtests/build.mk). It also reverted a
 different part of the fix I had originally submitted (part of the fix for
 make/libtool.mk), but I concede I don't remember why I had suggested that
 part of it, and it may not be needed. This change landed in qpdf 7.1.1.

 The one last remaining portion of the fix I originally submitted (the part
 for zlib-flate/build.mk) has not yet been committed. I sent a
 [https://github.com/qpdf/qpdf/pull/222 pull request for that] now;
 hopefully it will appear in a future version of qpdf. I also
 [changeset:46d610abd75f0822b675b02afaedff48a056470c/macports-ports
 committed the patch back to MacPorts] so the problem should be solved for
 us at least.

-- 
Ticket URL: <https://trac.macports.org/ticket/42101#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS