[MacPorts] #56572: fbthrift: update to 2018.05.28.00
MacPorts
noreply at macports.org
Fri Jun 1 22:07:19 UTC 2018
#56572: fbthrift: update to 2018.05.28.00
-------------------------+------------------------
Reporter: mohd-akram | Owner: ryandesign
Type: update | Status: accepted
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords:
Port: fbthrift |
-------------------------+------------------------
Comment (by mohd-akram):
Found the culprit.
In `./work/build/CMakeFiles/CMakeError.log`:
{{{
Building C object CMakeFiles/cmTC_513c0.dir/CheckSymbolExists.c.o
/usr/bin/clang -I/opt/local/include -pipe -Os -DNDEBUG
-I/opt/local/include -std=gnu++14 -arch x86_64 -mmacosx-version-min=10.13
-o CMakeFiles/cmTC_513c0.dir/CheckSymbolExists.c.o -c
/opt/local/var/macports/build/_Users_mohamed_.ports_devel_folly/folly/work/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c
error: invalid argument '-std=gnu++14' not allowed with 'C'
make[1]: *** [CMakeFiles/cmTC_513c0.dir/CheckSymbolExists.c.o] Error 1
make: *** [cmTC_513c0/fast] Error 2
File
/opt/local/var/macports/build/_Users_mohamed_.ports_devel_folly/folly/work/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:
/* */
#include <pthread.h>
int main(int argc, char** argv)
{
(void)argv;
#ifndef pthread_atfork
return ((int*)(&pthread_atfork))[argc];
#else
(void)argc;
return 0;
#endif
}
}}}
`clang` gives an error when passing an invalid `-std` argument, causing
`cmake` checks to fail, while GCC (tested with `gcc-mp-5`) treats it as a
warning.
The `std=gnu++14` argument is added
[https://github.com/facebook/folly/commit/c8d7b1383b3315a6bb7f7882c4a116fe990dee71
here].
I've attached a patch for this that removes that flag for C-based checks.
--
Ticket URL: <https://trac.macports.org/ticket/56572#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list