[MacPorts] #56581: GitHub Livecheck Fails on iperf3-devel Subport

[MacPorts]

#56581: GitHub Livecheck Fails on iperf3-devel Subport
--------------------+--------------------
 Reporter:  aque    |      Owner:  (none)
     Type:  defect  |     Status:  new
 Priority:  Normal  |  Milestone:
Component:  base    |    Version:  2.5.0
 Keywords:          |       Port:
--------------------+--------------------
 The [https://github.com/macports/macports-
 ports/blob/master/net/iperf3/Portfile iperf3-devel] subport currently has
 livecheck disabled as a workaround. When enabled, I get the following
 error:
 {{{#!text lineno=1, marks=11
 DEBUG: Starting logging for iperf3-devel
 DEBUG: macOS 10.13 (darwin/17.5.0) arch i386
 DEBUG: MacPorts 2.5.0
 DEBUG: Xcode 9.4
 DEBUG: SDK 10.13
 DEBUG: MACOSX_DEPLOYMENT_TARGET: 10.13
 DEBUG: Executing org.macports.main (iperf3-devel)
 DEBUG: livecheck phase started at Sat Jun  2 10:41:36 CDT 2018
 DEBUG: Executing org.macports.livecheck (iperf3-devel)
 DEBUG: Port (livecheck) version is
 3e58489a5823126fd1d51fcfb74994f9e8fe4e86
 DEBUG: Fetching https://github.com/esnet/iperf/tags
 DEBUG: The regex is
 "<id>tag:github.com,2008:Grit::Commit/([0-9a-f]{40})[0-9a-f]*</id>"
 Error: cannot check if iperf3-devel was updated (regex didn't match)
 }}}

 I suspect the `livecheck.url` in `github-1.0.tcl` was previously set by
 the main (iperf3) port and not updated. I made the following change to
 confirm:

 {{{#!diff
 diff --git a/_resources/port1.0/group/github-1.0.tcl
 b/_resources/port1.0/group/github-1.0.tcl
 index 5324573aa2..f7ba5f231f 100644
 --- a/_resources/port1.0/group/github-1.0.tcl
 +++ b/_resources/port1.0/group/github-1.0.tcl
 @@ -107,7 +107,7 @@ proc github.setup {gh_author gh_project gh_version
 {gh_tag_prefix ""} {gh_tag_su
          [regexp "^\[0-9a-f\]{7,}\$" ${github.version}] && \
          ![regexp "^\[0-9\]{8}\$" ${github.version}]} {
          livecheck.type      regexm
 -        default livecheck.url
 {${github.homepage}/commits/${github.livecheck.branch}.atom}
 +        livecheck.url
 ${github.homepage}/commits/${github.livecheck.branch}.atom
          livecheck.regex
 <id>tag:github.com,2008:Grit::Commit/(\[0-9a-f\]{[string length
 ${github.version}]})\[0-9a-f\]*</id>
      } else {
          livecheck.type      regex
 }}}

 This fixed the issue in this case. I did not test with other ports to see
 if this change breaks their livechecks.
 {{{#!text lineno=1, marks=11
 DEBUG: Starting logging for iperf3-devel
 DEBUG: macOS 10.13 (darwin/17.5.0) arch i386
 DEBUG: MacPorts 2.5.0
 DEBUG: Xcode 9.4
 DEBUG: SDK 10.13
 DEBUG: MACOSX_DEPLOYMENT_TARGET: 10.13
 DEBUG: Executing org.macports.main (iperf3-devel)
 DEBUG: livecheck phase started at Sat Jun  2 10:53:55 CDT 2018
 DEBUG: Executing org.macports.livecheck (iperf3-devel)
 DEBUG: Port (livecheck) version is
 3e58489a5823126fd1d51fcfb74994f9e8fe4e86
 DEBUG: Fetching https://github.com/esnet/iperf/commits/master.atom
 DEBUG: The regex is
 "<id>tag:github.com,2008:Grit::Commit/([0-9a-f]{40})[0-9a-f]*</id>"
 DEBUG: The regex matched
 "<id>tag:github.com,2008:Grit::Commit/7f883016bb77a39f11f6c62094c990a1dfef986e</id>",
 extracted "7f883016bb77a39f11f6c62094c990a1dfef986e"
 iperf3-devel seems to have been updated (port version:
 3e58489a5823126fd1d51fcfb74994f9e8fe4e86, new version:
 7f883016bb77a39f11f6c62094c990a1dfef986e)
 }}}

-- 
Ticket URL: <https://trac.macports.org/ticket/56581>
MacPorts <https://www.macports.org/>
Ports system for macOS