[MacPorts] #56581: GitHub Livecheck Fails on iperf3-devel Subport
MacPorts
noreply at macports.org
Sat Jun 2 21:07:19 UTC 2018
#56581: GitHub Livecheck Fails on iperf3-devel Subport
---------------------+----------------------
Reporter: aque | Owner: (none)
Type: defect | Status: new
Priority: Normal | Milestone:
Component: base | Version: 2.5.0
Resolution: | Keywords: haspatch
Port: iperf3 |
---------------------+----------------------
Comment (by ryandesign):
Replying to [ticket:56581 aque]:
> {{{#!diff
> diff --git a/_resources/port1.0/group/github-1.0.tcl
b/_resources/port1.0/group/github-1.0.tcl
> index 5324573aa2..f7ba5f231f 100644
> --- a/_resources/port1.0/group/github-1.0.tcl
> +++ b/_resources/port1.0/group/github-1.0.tcl
> @@ -107,7 +107,7 @@ proc github.setup {gh_author gh_project gh_version
{gh_tag_prefix ""} {gh_tag_su
> [regexp "^\[0-9a-f\]{7,}\$" ${github.version}] && \
> ![regexp "^\[0-9\]{8}\$" ${github.version}]} {
> livecheck.type regexm
> - default livecheck.url
{${github.homepage}/commits/${github.livecheck.branch}.atom}
> + livecheck.url
${github.homepage}/commits/${github.livecheck.branch}.atom
> livecheck.regex
<id>tag:github.com,2008:Grit::Commit/(\[0-9a-f\]{[string length
${github.version}]})\[0-9a-f\]*</id>
> } else {
> livecheck.type regex
> }}}
Your proposed change would break the ability of a port to override
`github.livecheck.branch`, a feature introduced in
[8c8cfbced424311973717d48f0193ad4e53820a3/macports-ports].
--
Ticket URL: <https://trac.macports.org/ticket/56581#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list