[MacPorts] #56581: GitHub Livecheck Fails on iperf3-devel Subport

[MacPorts]

#56581: GitHub Livecheck Fails on iperf3-devel Subport
---------------------+------------------------
  Reporter:  aque    |      Owner:  ryandesign
      Type:  defect  |     Status:  closed
  Priority:  Normal  |  Milestone:
 Component:  base    |    Version:  2.5.0
Resolution:  fixed   |   Keywords:  haspatch
      Port:  iperf3  |
---------------------+------------------------

Comment (by ryandesign):

 Replying to [comment:3 aque]:
 > I didn't know that restructuring the port that way would fix it; it
 reads the same to me.

 Before my change, `github.setup` was invoked once if the subport was
 iperf3, and twice if the subport was iperf3-devel (the first invocation
 set some livecheck parameters appropriately for the main port, and the
 second one overrode some but not all of them (not the ones specified with
 `default`) for the devel subport). Now, `github.setup` is invoked only
 once regardless of the subport, and so the livecheck parameters are set
 correctly.

 When I designed the github portgroup I didn't envision the situation where
 a developer would want to invoke `github.setup` differently in different
 subports. Some day I will try to make a new github 2.0 portgroup that
 avoids this and other mistakes I made in github 1.0.

-- 
Ticket URL: <https://trac.macports.org/ticket/56581#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS