[MacPorts] #56664: enable diff-highlight in git, with variant

MacPorts noreply at macports.org
Thu Jun 14 12:15:25 UTC 2018


#56664: enable diff-highlight in git, with variant
----------------------+----------------------
  Reporter:  iEFdev   |      Owner:  ci42
      Type:  request  |     Status:  assigned
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.5.2
Resolution:           |   Keywords:  haspatch
      Port:  git      |
----------------------+----------------------

Comment (by raimue):

 Variant names must not contain a minus as that would be ambiguous (it is
 used to negate variants). Apparently you have not tested this change, as
 the Portfile fails to parse.

 Your notes do not describe what "functionality" they refer to.

 Now that you added a post-build to build the script, would it not also
 required to be copied in the destroot phase?

-- 
Ticket URL: <https://trac.macports.org/ticket/56664#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list