[MacPorts] #55940: Don't import suffix into global namespace

[MacPorts]

#55940: Don't import suffix into global namespace
-------------------------+--------------------
 Reporter:  ryandesign   |      Owner:
     Type:  enhancement  |     Status:  new
 Priority:  Normal       |  Milestone:
Component:  base         |    Version:  2.4.99
 Keywords:               |       Port:
-------------------------+--------------------
 [browser:macports-base/src/port1.0/portfetch.tcl portfetch.tcl] has these
 lines:

 {{{
 # XXX import suffix into the global namespace as it is currently used from
 # Portfiles, but should better go somewhere else
 namespace import portfetch::suffix
 }}}

 We removed the use of the `suffix` proc from most portfiles years ago in
 commits such as these:

 * [4b17cbb3716d026817b217365904e8b3d68f2cc6/macports-ports]
 * [22eecff90e364bfa73f1191a0be46ebdd9de2fc0/macports-ports]
 * [21bd4313583cb7bdfe60b7a474c66ac0b912763f/macports-ports]

 The only remaining port using it is my FFView port and I should remove it
 from there too.

 So can we stop importing `suffix` into the global namespace now?

--
Ticket URL: <https://trac.macports.org/ticket/55940>
MacPorts <https://www.macports.org/>
Ports system for macOS