[MacPorts] #55757: port submission: p5-opencl
MacPorts
noreply at macports.org
Sat Mar 17 11:09:14 UTC 2018
#55757: port submission: p5-opencl
-------------------------+-----------------
Reporter: dsteck | Owner:
Type: submission | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords:
Port: p5-opencl |
-------------------------+-----------------
Comment (by mojca):
* since the time you made the submission we retired perl 5.24 modules, so
only the 5.26 should be kept
* size is usually in the last line (`port -v extract` will automatically
give you the output even if those lines are missing, but it only reports
size if you use development version of MacPorts; I've never added size
myself and it has not been a requirement yet, but we'll start introducing
it soon, so it doesn't hurt to keep it)
* are you willing to be a maintainer of the port
* instead of setting up the `master_sites`, here's what other perl ports
do (this is just for perl, not for other ports), you can try if that works
for you:
{{{
perl5.setup Path-IsDev 1.001003 ../by-authors/id/K/KE/KENTNL
}}}
* if you use `patchfiles` instead of `patchfiles-append`, the line with
two patches will most likely delete the darwin-specific patch
* whitespace in front of `platform darwin` should use 4 spaces, not two
(some nitpicking)
Any of those things can also be fixed by the person committing your port
(this is less true in case you submit a pull requests since there's a huge
difference in just pushing the merge button and having to fix something).
Officially we support patch submission via Trac. But unofficial lesson
learned is that there are some super active members of community that only
ever look at pull requests on github and never check Trac. So if you want
to increase your chances to get your patches accepted faster (probably by
10-fold?), your best bet is to submit a pull request.
--
Ticket URL: <https://trac.macports.org/ticket/55757#comment:8>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list