[MacPorts] #55577: getting rid of unforeseen -I${prefix}/include option adding and its potential side-effects

MacPorts noreply at macports.org
Sat Mar 24 07:54:29 UTC 2018


#55577: getting rid of unforeseen -I${prefix}/include option adding and its
potential side-effects
--------------------------+--------------------
  Reporter:  RJVB         |      Owner:
      Type:  enhancement  |     Status:  closed
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:  wontfix      |   Keywords:
      Port:  pcre, glib2  |
--------------------------+--------------------

Comment (by ryandesign):

 In [changeset:"db9f7311c52cf7ad198a8aff1fd9c80e8f11d8b5/macports-ports"
 db9f7311c52cf7ad198a8aff1fd9c80e8f11d8b5/macports-ports]:
 {{{
 #!ConfigurableCommitTicketReference repository="macports-ports"
 revision="db9f7311c52cf7ad198a8aff1fd9c80e8f11d8b5"
 glib2: Update to 2.56.0

 Closes: https://trac.macports.org/ticket/56081

 Also, patch configure.ac, not configure. The reason why we were patching
 configure was that patching configure.ac would have required running
 autoreconf, and that would have required pkg-config, and at the time,
 pkg-config depended on glib2, and MacPorts cannot accommodate circular
 dependencies. pkg-config has included its own private copy of glib2
 since f0e3b8c11602b61d2ac6d9ec1f69541c1d197257, so this reason no
 longer applies.

 We have been maintaining a large configure patch which needs to be
 tediously regenerated from the configure.ac patch whenever glib2 is
 updated. That effort is saved by being able to use the configure.ac
 patch directly.

 The Portfile is also simplified by allowing pkg-config to find the
 libraries of the dependencies, rather than having to specify each of
 them manually.

 Reverts 847ba0283b0e043211bcaa4f2f6824f5f290dfa5.

 See: https://trac.macports.org/ticket/55577

 Also, add SIZEOF_SSIZE_T handling to config.h.ed. This should have been
 done in 2eb6602f8fbd933b0337bcf89bbcdcb233e8148a when similar patching
 was added to the configure script. Add a comment to the patch to remind
 the maintainer to update config.h.ed too.

 Also, no longer undefine AC_APPLE_UNIVERSAL_BUILD in config.h. It's
 unclear why we were ever doing this. config.h is only used at build
 time. The only thing AC_APPLE_UNIVERSAL_BUILD currently does is ensure
 WORDS_BIGENDIAN is defined correctly. glib doesn't use WORDS_BIGENDIAN;
 it uses its own G_BYTE_ORDER, G_BIG_ENDIAN and G_LITTLE_ENDIAN. Maybe
 AC_APPLE_UNIVERSAL_BUILD used to do something more objectionable.
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/55577#comment:16>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list