[MacPorts] #56168: gnome-internet-radio-locator 1.0.7 +quartz

[MacPorts]

#56168: gnome-internet-radio-locator 1.0.7 +quartz
-------------------------------------------+-----------------
  Reporter:  oleaamot                      |      Owner:
      Type:  update                        |     Status:  new
  Priority:  Normal                        |  Milestone:
 Component:  ports                         |    Version:
Resolution:                                |   Keywords:
      Port:  gnome-internet-radio-locator  |
-------------------------------------------+-----------------

Comment (by ryandesign):

 The update to 1.0.7 is fine, but the rest is not:

 * There are two nested `pre-configure` blocks.
 * You're enabling the gtk3 and x11 variants by default, but the port
 doesn't have any such variants. I'm assuming you meant to add them, but
 forgot?
 * You're checking whether gtk3 is installed with +quartz by checking for
 the existence of a file; that method has been obsolete for years. Instead,
 please use `PortGroup active_variants 1.1` (at the top of the Portfile)
 and `require_active_variants gtk3 +quartz` (in the quartz variant—assuming
 the quartz variant were changed to declare that it requires the thus far
 nonexistent gtk3 variant).
 * I am assuming here that gnome-internet-radio-locator builds itself in
 some way differently when gtk3 is installed with quartz vs when it is not;
 otherwise, it wouldn't make sense to declare an empty quartz variant.

--
Ticket URL: <https://trac.macports.org/ticket/56168#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS