[MacPorts] #56466: QtCurve-extra: universal variant fails
MacPorts
noreply at macports.org
Sat May 12 14:55:48 UTC 2018
#56466: QtCurve-extra: universal variant fails
----------------------------+--------------------
Reporter: ryandesign | Owner: (none)
Type: defect | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords:
Port: QtCurve-extra |
----------------------------+--------------------
Comment (by ryandesign):
The muniversal portgroup currently defines a universal variant when you
include it. It also defines procedures and options that relate to that
universal variant. If you don't want a universal variant, don't include
the portgroup. It's always been as simple as that.
The simplest solution for your portfile is therefore to include the
portgroup only if `${subport} ne "${name}-extra"`.
If you want to change the behavior of the portgroup so that it does not
define the universal variant if `${supported_archs} eq "noarch"`, that
would require supported_archs to be declared before the portgroup is
included. Portgroups are usually included at the top of the portfile, and
in your portfile, you do include the portgroup before setting
supported_archs.
Your patch makes the portgroup's universal variant print an error if
`${supported_archs} eq noarch`. That might be a reasonable safeguard to
have in the portgroup, but it does not excuse the portfile from using the
portgroup correctly. We don't usually want ports to have variants that do
nothing but print an error.
--
Ticket URL: <https://trac.macports.org/ticket/56466#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list