[MacPorts] #56518: gdal @2.3.0 uses zstd without declaring a dependency on it

[MacPorts]

#56518: gdal @2.3.0 uses zstd without declaring a dependency on it
------------------------+----------------------
 Reporter:  ryandesign  |      Owner:  Veence
     Type:  defect      |     Status:  assigned
 Priority:  Normal      |  Milestone:
Component:  ports       |    Version:
 Keywords:              |       Port:  gdal
------------------------+----------------------
 gdal @2.3.0 fails to install with the universal variant on my system:

 {{{
 $ sudo port -u upgrade gdal
 --->  Computing dependencies for gdal
 --->  Fetching archive for gdal
 --->  Attempting to fetch
 gdal-2.3.0_0+expat+openjpeg+universal.darwin_16.i386-x86_64.tbz2 from
 https://packages.macports.org/gdal
 --->  Fetching distfiles for gdal
 --->  Verifying checksums for gdal
 --->  Extracting gdal
 --->  Applying patches to gdal
 --->  Configuring gdal
 --->  Building gdal
 --->  Staging gdal into destroot
 Error: Failed to destroot gdal: gdal-config differs in
 /opt/local/var/macports/build/_Users_rschmidt_macports_macports-ports-svn-
 trunk_gis_gdal/gdal/work/destroot-i386//opt/local/bin and
 /opt/local/var/macports/build/_Users_rschmidt_macports_macports-ports-svn-
 trunk_gis_gdal/gdal/work/destroot-x86_64//opt/local/bin and cannot be
 merged
 Error: See /opt/local/var/macports/logs/_Users_rschmidt_macports_macports-
 ports-svn-trunk_gis_gdal/gdal/main.log for details.
 Error: Follow https://guide.macports.org/#project.tickets to report a bug.
 }}}

 The difference between the two files is that in the x86_64 file,
 `CONFIG_DEP_LIBS` contains `-lzstd` while in the i386 file it does not.

 I do have /opt/local/lib/libzstd.dylib on my system, provided by the zstd
 @1.3.3_0 port, and it is not installed with the universal variant, which
 explains the merge failure.

 So the real bug is that gdal uses zstd without declaring a dependency on
 it. Either declare a dependency on zstd, or don't use zstd even if it is
 already installed; either way, the revision will need to be increased.

-- 
Ticket URL: <https://trac.macports.org/ticket/56518>
MacPorts <https://www.macports.org/>
Ports system for macOS