[MacPorts] #57693: spooles: new port
MacPorts
noreply at macports.org
Thu Nov 29 00:00:19 UTC 2018
#57693: spooles: new port
-------------------------+--------------------
Reporter: mbrethen | Owner: (none)
Type: submission | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords:
Port: spooles |
-------------------------+--------------------
Comment (by ryandesign):
`-macosx_version_min ${os.version}` is not correct (`${os.version}` is the
Darwin version number but you want the macOS version number here); use
`-macosx_version_min ${macosx_deployment_target}` instead.
The destroot phase should probably copy the libraries into the destroot
like other ports do, rather than moving them there.
Could the doc variant be removed, and the documentation just always
installed? Or is the documentation huge?
I see lots of unversioned distfiles here, though the main file is
versioned. Will the unversioned files ever change? If so, using a
versioned `dist_subdir` might be best (PortfileRecipes#unversioned-
distfiles).
Wait, I see now that the unversioned distfiles are documentation files.
But it looks like the port downloads those files even when they're not
going to be installed. So I would suggest changing it one of two ways:
1. Only download the documentation files if the doc variant is selected,
or
2. Remove the doc variant and make a separate spooles-doc subport to
install the documentation, and have this subport download only the
documentation, while the main port downloads only the source code. This is
probably the best option, because it allows a user to install the
documentation later without having to rebuild the library, and because it
allows you to use a separate `version`, `revision`, and/or `dist_subdir`
for the spooles-doc subport, so that the documentation files only need to
be redownloaded and reinstalled if they have actually changed. It also
allows you to specify a different license for the documentation, if
necessary.
Though I guess if these files were last modified in 1999 there probably
aren't ever going to be any more releases.
The `livecheck.regex` is not correct, but given the unlikelihood of
another release, maybe `livecheck.type none` is the best fix for that.
--
Ticket URL: <https://trac.macports.org/ticket/57693#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list