[MacPorts] #57256: gtkglext has enormous configure patches

MacPorts noreply at macports.org
Fri Oct 5 00:03:44 UTC 2018


#57256: gtkglext has enormous configure patches
------------------------+----------------------
 Reporter:  ryandesign  |      Owner:  jd@…
     Type:  defect      |     Status:  assigned
 Priority:  Normal      |  Milestone:
Component:  ports       |    Version:
 Keywords:              |       Port:  gtkglext
------------------------+----------------------
 gtkglext's files directory has 2 enormous (> 750 KiB, > 22,000 line)
 patchfiles for the configure script, one of which isn't even used by the
 portfile.

 Nobody is going to be able to read patchfiles that large to determine what
 they change or why or be able to update them in the future, which is
 probably one reason why they haven't been touched in 9 years.

 The patches were originally added due to #20968. Rolf, do you remember how
 the configure patches were created?

 The diffs are so large because the configure script was originally
 generated by autoconf 2.59 and the revised version was generated by
 autoconf 2.61.

 If the diffs merely regenerate the configure script with a newer version
 of autoconf, then it would be simpler to remove the configure patchfiles
 and just have the portfile run autoreconf.

 If configure.ac had also been changed before autoreconf was run, then it
 would be simpler to have the port patch configure.ac and then run
 autoreconf.

-- 
Ticket URL: <https://trac.macports.org/ticket/57256>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list