[MacPorts] #58283: VLC fails to configure when running with trace

[MacPorts]

#58283: VLC fails to configure when running with trace
--------------------------------+----------------------
  Reporter:  jonnyflash-owlgod  |      Owner:  RJVB
      Type:  defect             |     Status:  assigned
  Priority:  Normal             |  Milestone:
 Component:  ports              |    Version:  2.5.4
Resolution:                     |   Keywords:
      Port:  VLC                |
--------------------------------+----------------------

Comment (by kencu):

 So this is the error:
 {{{
 :info:build access/sftp.c:310:14: error: use of undeclared identifier
 'LIBSSH2_HOSTKEY_TYPE_ECDSA_256'
 :info:build         case LIBSSH2_HOSTKEY_TYPE_ECDSA_256:
 :info:build              ^
 :info:build access/sftp.c:311:42: error: use of undeclared identifier
 'LIBSSH2_KNOWNHOST_KEY_ECDSA_256'
 :info:build             knownhost_fingerprint_algo =
 LIBSSH2_KNOWNHOST_KEY_ECDSA_256;
 :info:build                                          ^
 :info:build access/sftp.c:314:14: error: use of undeclared identifier
 'LIBSSH2_HOSTKEY_TYPE_ECDSA_384'
 :info:build         case LIBSSH2_HOSTKEY_TYPE_ECDSA_384:
 :info:build              ^
 :info:build access/sftp.c:315:42: error: use of undeclared identifier
 'LIBSSH2_KNOWNHOST_KEY_ECDSA_384'
 :info:build             knownhost_fingerprint_algo =
 LIBSSH2_KNOWNHOST_KEY_ECDSA_384;
 :info:build                                          ^
 :info:build access/sftp.c:318:14: error: use of undeclared identifier
 'LIBSSH2_HOSTKEY_TYPE_ECDSA_521'
 :info:build         case LIBSSH2_HOSTKEY_TYPE_ECDSA_521:
 :info:build              ^
 :info:build access/sftp.c:319:42: error: use of undeclared identifier
 'LIBSSH2_KNOWNHOST_KEY_ECDSA_521'
 :info:build             knownhost_fingerprint_algo =
 LIBSSH2_KNOWNHOST_KEY_ECDSA_521;
 :info:build                                          ^
 }}}

 Those constants are supposedly guarded to prevent this kind of error, in
 `sftp.c`:
 {{{
   309 #if LIBSSH2_VERSION_NUM >= 0x010801
   310         case LIBSSH2_HOSTKEY_TYPE_ECDSA_256:
   311             knownhost_fingerprint_algo =
 LIBSSH2_KNOWNHOST_KEY_ECDSA_256;
   312             break;
   313
   314         case LIBSSH2_HOSTKEY_TYPE_ECDSA_384:
   315             knownhost_fingerprint_algo =
 LIBSSH2_KNOWNHOST_KEY_ECDSA_384;
   316             break;
   317
   318         case LIBSSH2_HOSTKEY_TYPE_ECDSA_521:
   319             knownhost_fingerprint_algo =
 LIBSSH2_KNOWNHOST_KEY_ECDSA_521;
   320             break;
   321 #endif
 }}}

 And I confirm that when I try to build `vlc` on my Mojave system, I get
 the same error. So something is amiss, indeed.

-- 
Ticket URL: <https://trac.macports.org/ticket/58283#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS