[MacPorts] #58290: port lint should check sub-ports

MacPorts noreply at macports.org
Tue Apr 2 21:55:16 UTC 2019


#58290: port lint should check sub-ports
--------------------------+--------------------
  Reporter:  reneeotten   |      Owner:  (none)
      Type:  enhancement  |     Status:  new
  Priority:  Normal       |  Milestone:
 Component:  base         |    Version:
Resolution:               |   Keywords:
      Port:               |
--------------------------+--------------------

Comment (by ryandesign):

 The problem is that `port lint` does two different kinds of checks:

  1. it reads the Portfile line by line and checks for certain syntactic
 and stylistic errors
  2. it checks the variables that MacPorts base has set after processing
 the Porfile and validates their values

 Before subports existed, this distinction wasn't too important, but now
 that we have subports, it's a little confusing because the first check
 covers the entire Portfile while the second check only covers the
 specified subport.

 I don't see anywhere in `proc portlint::lint_main` where it tells MacPorts
 to populate the variables for the specified subport, so I assume MacPorts
 base has already done that before calling `portlint::lint_main`. That
 makes it difficult to have `port lint` check the variables of more than
 just the specified subport.

-- 
Ticket URL: <https://trac.macports.org/ticket/58290#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list