[MacPorts] #57875: port:poppler shouldn't require C++14?!

[MacPorts]

#57875: port:poppler shouldn't require C++14?!
----------------------+---------------------
  Reporter:  RJVB     |      Owner:  dbevans
      Type:  defect   |     Status:  closed
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:  invalid  |   Keywords:
      Port:  poppler  |
----------------------+---------------------
Changes (by dbevans):

 * status:  assigned => closed
 * resolution:   => invalid


Comment:

 Addressing @RJVBs concerns with C++14, thread_local storage, and
 blacklisting of Apple clang versions:

 As I think you know, poppler started requiring a C++14 compiler in
 https://gitlab.freedesktop.org/poppler/poppler/commit/9bfc10eecb57354270806aa1d9278eebb1db2287.
 This also introduced the use of std::make_unique to replace
 std::unique_ptr as discussed above.

 C++14 requires Apple clang 600.0.54 or later. See
 https://trac.macports.org/wiki/CompilerSelection.

 As a separate issue, poppler introduced the use of thread_local in
 https://gitlab.freedesktop.org/poppler/poppler/commit/c46717a70341ac0120579c867d49c250bed4ed52.

 Although vanilla clang supported thread_local earlier, for their own
 policy reasons, it is my understanding that Apple did not support
 thread_local in clang until much later (800.0.38 Xcode 8).

 The current configuration allows poppler to build on all platforms from at
 least 10.6+ per the buildbots.

 See https://stackoverflow.com/questions/28094794/why-does-apple-clang-
 disallow-c11-thread-local-when-official-clang-supports for a statement of
 Apple's position in 2014.

 My position is to support poppler as provided upstream, rather than to
 second guess them.  If you disagree, you should bring it up with them.

-- 
Ticket URL: <https://trac.macports.org/ticket/57875#comment:14>
MacPorts <https://www.macports.org/>
Ports system for macOS