[MacPorts] #57950: port selfupdate gives the impression of doing work in the wrong order
MacPorts
noreply at macports.org
Wed Jan 23 17:52:56 UTC 2019
#57950: port selfupdate gives the impression of doing work in the wrong order
-------------------------+--------------------
Reporter: saagarjha | Owner: (none)
Type: enhancement | Status: new
Priority: Low | Milestone:
Component: base | Version: 2.5.4
Keywords: | Port:
-------------------------+--------------------
When running port selfupdate, the order in which output appears looks
something like this:
{{{
$ port selfupdate
---> Updating MacPorts base sources using rsync
MacPorts base version 2.5.4 installed,
MacPorts base version 2.5.4 downloaded.
---> Updating the ports tree
---> MacPorts base is already the latest version
}}}
From a end-user perspective, it seems odd that MacPorts needed to update
the ports tree before telling me that I have the latest version,
considering that it tells me the version I have before this (which should
be enough for it to determine this?). I'd expect the output to look like
this, to match the logic operations that are being performed:
{{{
$ port selfupdate
---> Updating MacPorts base sources using rsync
MacPorts base version 2.5.4 installed,
MacPorts base version 2.5.4 downloaded.
---> MacPorts base is already the latest version
---> Updating the ports tree
}}}
Looking at [https://github.com/macports/macports-
base/blob/master/src/macports1.0/selfupdate.tcl#L161 the source code] for
selfupdate, it seems that this is done mainly because it simplifies a
conditional, but I see no reason why this couldn't be changed to display
the messages at the logical point that they should appear.
--
Ticket URL: <https://trac.macports.org/ticket/57950>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list