[MacPorts] #58665: octave portgroup's post-extract phase conflicts with macports master
MacPorts
noreply at macports.org
Mon Jul 1 02:58:29 UTC 2019
#58665: octave portgroup's post-extract phase conflicts with macports master
------------------------+--------------------
Reporter: ryandesign | Owner: (none)
Type: defect | Status: new
Priority: Normal | Milestone:
Component: ports | Version: 2.5.99
Keywords: | Port: octave
------------------------+--------------------
The [browser:macports-ports/_resources/port1.0/group/octave-1.0.tcl octave
portgroup] mucks with the directory name after extraction:
{{{
post-extract {
# rename the effective worksrcdir to always be ${octave.module}
set worksrcdir_name [exec /bin/ls ${workpath} | grep -v -E "^\\."]
if {[string equal ${worksrcdir_name} ${octave.module}] == 0} {
# work-around for case-insensitive file systems when the
# extract directory name is the same as the octave module name
# except for letter case; should always work no matter if the
# file system is case-insensitive or case-sensitive.
move ${workpath}/${worksrcdir_name}
${workpath}/tmp-${worksrcdir_name}
move ${workpath}/tmp-${worksrcdir_name}
${workpath}/${octave.module}
}
}
}}}
This (especially its use of `ls` and its assumption that there will only
be one line of output) does not work when used with MacPorts master
(2.5.99) which uses [https://github.com/macports/macports-base/pull/55 a
different approach] to fix the worksrcdir (creating a symlink if
necessary). The octave portgroup needs to become compatible with this new
approach, while remaining compatible with released versions of MacPorts
2.5.x until 2.6 comes out with the fixes from master.
--
Ticket URL: <https://trac.macports.org/ticket/58665>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list