[MacPorts] #58552: harfbuzz @2.5.1 does not build on PPC Leopard, Mac OS X 10.5.8, because some warnings being treated as errors

MacPorts noreply at macports.org
Mon Jun 3 23:43:39 UTC 2019


#58552: harfbuzz @2.5.1 does not build on PPC Leopard, Mac OS X 10.5.8, because
some warnings being treated as errors
------------------------+---------------------
  Reporter:  ballapete  |      Owner:  (none)
      Type:  defect     |     Status:  new
  Priority:  Normal     |  Milestone:
 Component:  ports      |    Version:  2.5.4
Resolution:             |   Keywords:  leopard
      Port:  harfbuzz   |
------------------------+---------------------

Comment (by ballapete):

 These are the lines on which the patched variables are used:

 {{{
   47:#define HB_CORETEXT_DEFAULT_FONT_SIZE 12.f
   50:coretext_font_size_from_ptem (float ptem)
   57:  ptem *= ((CGFloat) 96.f) / ((CGFloat) 72.f);
 «===
   58:  return (CGFloat) (ptem <= 0.f ? HB_CORETEXT_DEFAULT_FONT_SIZE :
 ptem);
   61:coretext_font_size_to_ptem (CGFloat size)
   63:  size *= ((CGFloat) 72.) / ((CGFloat) 96.);
 «===
   64:  return size <= 0 ? 0 : size;
  126:release_data (void *info, const void *data, size_t size)
  128:  assert (hb_blob_get_length ((hb_blob_t *) info) == size &&
  320:  CTFontRef ct_font = create_ct_font (cg_font,
 coretext_font_size_from_ptem (font->ptem));
  344:  if (hb_CGFloat_abs (CTFontGetSize((CTFontRef) data) -
 coretext_font_size_from_ptem (font->ptem)) > (CGFloat) .5) «===
  820:    double advances_so_far = 0;
  828:      advances_so_far -= CTLineGetTrailingWhitespaceWidth (line);
  830:     advances_so_far = -advances_so_far;
  842:      double run_advance = CTRunGetTypographicBounds (run, range_all,
 nullptr, nullptr, nullptr);
  844:     run_advance = -run_advance;
  845:      DEBUG_MSG (CORETEXT, run, "Run advance: %g", run_advance);
  921:     hb_position_t advance = x_advance + y_advance;
  943:         info->mask = advance;
  952:     advances_so_far += run_advance;
 1021:     hb_position_t x_offset = (positions[0].x - ((CGFloat)
 advances_so_far)) * x_mult;     «===
 1024:       CGFloat advance;
 «===
 1026:         advance = positions[j + 1].x - positions[j].x;
 1028:         advance = ((CGFloat) run_advance) - (positions[j].x -
 positions[0].x);            «===
 1029:       info->mask = advance * x_mult;
 1037:     hb_position_t y_offset = (positions[0].y - ((CGFloat)
 advances_so_far)) * y_mult;     «===
 1040:       CGFloat advance;
 «===
 1042:         advance = positions[j + 1].y - positions[j].y;
 1044:         advance = ((CGFloat) run_advance) - (positions[j].y -
 positions[0].y);            «===
 1045:       info->mask = advance * y_mult;
 1052:   advances_so_far += run_advance;
 }}}

 Harfbuzz built, harfbuzz-icu has built too.

-- 
Ticket URL: <https://trac.macports.org/ticket/58552#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list