[MacPorts] #55445: install phase fails with "no destroot found"

[MacPorts]

#55445: install phase fails with "no destroot found"
----------------------------+----------------------
  Reporter:  gaming-hacker  |      Owner:  (none)
      Type:  defect         |     Status:  assigned
  Priority:  Normal         |  Milestone:
 Component:  base           |    Version:  2.4.2
Resolution:                 |   Keywords:
      Port:                 |
----------------------------+----------------------

Comment (by ryandesign):

 I don't believe that all of the users who have reported this problem over
 the years are manually deleting their destroots. There must be a bug in
 base that causes it to do so, or more likely causes it to not create the
 destroot (maybe not even run the destroot phase) in the first place.

 In src/package1.0/portarchivefetch.tcl in `proc
 portarchivefetch::fetchfiles` we have this code:

 {{{
     if {[info exists archive_exists]} {
         # modify state file to skip remaining phases up to destroot
         global target_state_fd
         foreach target {fetch checksum extract patch configure build
 destroot} {
             write_statefile target "org.macports.${target}"
 $target_state_fd
         }
         return 0
     }
 }}}

 I wonder if `[info exists archive_exists]` might be unexpectedly true in
 some situation, whereupon we would mark all the phases up to destroot
 complete, even though we should not have.

-- 
Ticket URL: <https://trac.macports.org/ticket/55445#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS