[MacPorts] #59650: kmymoney-devel: error: ordered comparison between pointer and zero (was: kmymoney-devel fails after port rev-upgrade)

[MacPorts]

#59650: kmymoney-devel: error: ordered comparison between pointer and zero
------------------------------+--------------------
  Reporter:  StanSanderson    |      Owner:  (none)
      Type:  defect           |     Status:  closed
  Priority:  Normal           |  Milestone:
 Component:  ports            |    Version:  2.6.2
Resolution:  duplicate        |   Keywords:
      Port:  kmymoney4-devel  |
------------------------------+--------------------
Changes (by ryandesign):

 * status:  new => closed
 * resolution:   => duplicate


Old description:

> Following port self update, port upgrade outdated consistently ends with
> --->  Scanning binaries for linking errors
> --->  Found 2 broken files, matching files to ports
> --->  Found 1 broken port, determining rebuild order
> You can always run 'port rev-upgrade' again to fix errors.
> The following ports will be rebuilt: kmymoney4-devel @4.8.1-20171206
>
> port installed kmymon* returns
>   kmymoney4-devel @4.8.1-20171206_2 (active)
>
> an excerpt of the main.log is attached.
> OS X 10.14.6

New description:

 Following port self update, `port upgrade outdated` consistently ends with
 {{{
 --->  Scanning binaries for linking errors
 --->  Found 2 broken files, matching files to ports
 --->  Found 1 broken port, determining rebuild order
 You can always run 'port rev-upgrade' again to fix errors.
 The following ports will be rebuilt: kmymoney4-devel @4.8.1-20171206

 port installed kmymon* returns
   kmymoney4-devel @4.8.1-20171206_2 (active)
 }}}

 an excerpt of the main.log is attached.\\
 OS X 10.14.6

--

Comment:

 The log shows the error is:

 {{{
 :info:build
 /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_kmymoney4-devel/kmymoney4-devel/work/kmymoney/kmymoney/mymoney/mymoneyreport.cpp:822:29:
 error: ordered comparison between pointer and zero ('const void *' and
 'int')
 :info:build   return (list.contains(id) > 0);
 :info:build           ~~~~~~~~~~~~~~~~~ ^ ~
 :info:build 1 error generated.
 :info:build make[2]: ***
 [kmymoney/mymoney/CMakeFiles/kmm_mymoney.dir/mymoneyreport.cpp.o] Error 1
 }}}

 Ordered comparisons between pointers and zero are always a developer
 mistake, but clang has only started reporting it as an error in recent
 versions.

 Duplicate of #58364.

-- 
Ticket URL: <https://trac.macports.org/ticket/59650#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS