[MacPorts] #59743: clamav-server: destroot patch failed

[MacPorts]

#59743: clamav-server: destroot patch failed
------------------------+---------------------------
 Reporter:  ryandesign  |      Owner:  essandess
     Type:  defect      |     Status:  assigned
 Priority:  Normal      |  Milestone:
Component:  ports       |    Version:  2.6.2
 Keywords:              |       Port:  clamav-server
------------------------+---------------------------
 https://build.macports.org/builders/ports-10.15_x86_64-builder/builds/3026/steps
 /install-port/logs/stdio

 {{{
 DEBUG: Executing org.macports.destroot (clamav-server)
 xinstall: mkdir /opt/local/var/macports/build
 /_opt_bblocal_var_buildworker_ports_build_ports_sysutils_clamav-server
 /clamav-server/work/destroot/opt/local/var/clamav
 xinstall: mkdir /opt/local/var/macports/build
 /_opt_bblocal_var_buildworker_ports_build_ports_sysutils_clamav-server
 /clamav-server/work/destroot/opt/local/var/log/clamav
 xinstall: mkdir /opt/local/var/macports/build
 /_opt_bblocal_var_buildworker_ports_build_ports_sysutils_clamav-server
 /clamav-server/work/destroot/opt/local/var/run/clamav
 xinstall: mkdir /opt/local/var/macports/build
 /_opt_bblocal_var_buildworker_ports_build_ports_sysutils_clamav-server
 /clamav-server/work/destroot/opt/local/share/clamav
 xinstall: /opt/local/etc/clamd.conf.sample ->
 /opt/local/var/macports/build
 /_opt_bblocal_var_buildworker_ports_build_ports_sysutils_clamav-server
 /clamav-server/work/destroot/opt/local/etc/clamd.conf.macports
 DEBUG: system -W /opt/local/var/macports/build
 /_opt_bblocal_var_buildworker_ports_build_ports_sysutils_clamav-server
 /clamav-server/work/destroot/opt/local: patch -p1
 ./etc/clamd.conf.macports
 /opt/bblocal/var/buildworker/ports/build/ports/sysutils/clamav-
 server/files/patch-etc-clamd-conf-macports.diff
 patching file ./etc/clamd.conf.macports
 Hunk #6 FAILED at 156.
 Hunk #7 succeeded at 176 (offset -1 lines).
 Hunk #8 succeeded at 302 (offset -1 lines).
 Hunk #9 succeeded at 319 with fuzz 1 (offset -1 lines).
 Hunk #10 succeeded at 335 (offset -1 lines).
 1 out of 10 hunks FAILED -- saving rejects to file
 ./etc/clamd.conf.macports.rej
 Command failed: patch -p1 ./etc/clamd.conf.macports
 /opt/bblocal/var/buildworker/ports/build/ports/sysutils/clamav-
 server/files/patch-etc-clamd-conf-macports.diff
 Exit code: 1
 Error: Failed to destroot clamav-server: command execution failed
 }}}

 The hunk that's failing is:

 {{{
 @@ -156,7 +156,7 @@
  #SendBufTimeout 200

  # Maximum number of queued items (including those being processed by
 -# MaxThreads threads)
 +MaxThreads 6
  # It is recommended to have this value at least twice MaxThreads if
 possible.
  # WARNING: you shouldn't increase this too much to avoid running out  of
 file
  # descriptors,
 }}}

 because there's now a period after the closing parenthesis.

 But why did this build successfully in June? It looks like this is because
 the file it's patching here (a copy of /opt/local/etc/clamd.conf.sample)
 doesn't come from this port; it comes from the clamav port. This is a
 pretty strange situation. Ports don't usually patch other ports' files. If
 it's going to continue to be that way, then that means that clamav-server
 should be revbumped (and possibly the patch will need to be changed)
 anytime the clamav port is updated in such a way that this conf file is
 changed. So at minimum a note should be added to the clamav port advising
 its maintainer of that.

 And more importantly, why is this hunk in the patchfile at all? It looks
 totally wrong, like the result of a bad global search-replace.
 (`MaxThreads 6` already appears in the correct place earlier in the file.)

-- 
Ticket URL: <https://trac.macports.org/ticket/59743>
MacPorts <https://www.macports.org/>
Ports system for macOS