[MacPorts] #59360: libvpx: configure.sdkroot: command not found

[MacPorts]

#59360: libvpx: configure.sdkroot: command not found
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  dbevans
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.1
Resolution:              |   Keywords:
      Port:  libvpx      |
-------------------------+----------------------

Comment (by Gcenx):

 Replying to [comment:2 kencu]:
 > But we have systems using libvpx that go back to 10.5. It is going to
 need more testing that just on 10.14.

 The pull-request had passed all tests, while I'm compiling on 10.14 I'm
 using Xcode11 with the 10.13 SDK without installing the additional headers
 package.
 Even with the following found within the builders logs, it still built
 {{{
 ./build/make/configure.sh: line 857: configure.sdkroot: command not found
 }}}

 I can personally test down to 10.8 maybe even 10.6.8, I don't have access
 to anything running 10.5

 I could add
 {{{
 build.args-append \
 configure.cflags-append   -isysroot${configure.sdkroot} \
 configure.ldflags-append  -isysroot${configure.sdkroot}
 }}}
 Into the Portfile in combination with the above patch.


 Replying to [comment:3 kencu]:
 > You might set a variable in the Portfile to the value of
 ${configure.skdroot} and pass it in to the shell script on the build line.
 >
 > I've seen Jeremy do that many times, eg <https://github.com/macports
 /macports-ports/blob/master/lang/libcxx/Portfile#L192>
 >
 > or similarly with setting a build env var.

 True, I could just add;
 {{{
 build.args-append \
 configure.cflags-append   -isysroot${configure.sdkroot} \
 configure.ldflags-append  -isysroot${configure.sdkroot}
 }}}


 Replying to [comment:4 jmroot]:
 > It may have built, but did it build against the right SDK? If it uses
 the -isysroot flag that MacPorts puts in CFLAGS then it is indeed fine. If
 not it needs to be fixed to do that.

 I'm using Xcode11 and Mojave . I haven't install the additional headers
 package onto my system so if -isysroot wasn't being passed the build would
 have definitely failed on my system.
 Within macports.conf I had added
 {{{
 macosx_deployment_target     10.13
 macosx_sdk_version           10.13
 }}}
 So I could build as universal, removing the above `libvpx` still builts of
 course not as universal but it still built.

 I could always use the above patch and add
 {{{
 build.args-append \
 configure.cflags-append   -isysroot${configure.sdkroot} \
 configure.ldflags-append  -isysroot${configure.sdkroot}
 }}}
 into the Portfile

-- 
Ticket URL: <https://trac.macports.org/ticket/59360#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS