[MacPorts] #59360: libvpx: configure.sdkroot: command not found

[MacPorts]

#59360: libvpx: configure.sdkroot: command not found
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  dbevans
      Type:  defect      |     Status:  accepted
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.1
Resolution:              |   Keywords:
      Port:  libvpx      |
-------------------------+----------------------

Comment (by ryandesign):

 Replying to [comment:8 Gcenx]:
 > I got home and tested that same issue
 > {{{
 > :info:configure ./build/make/configure.sh: line 857: SDKROOT: command
 not found
 > }}}
 > as you pointed out the script won't know what $(SDKROOT) is since it's a
 shell script, unless its injected as an env variable.

 In shell syntax, `$(SDKROOT)` is ''not'' how you would refer to an
 environment variable named SDKROOT*; that's how you would refer to a shell
 command or function named SDKROOT, and there isn't one. If you had wanted
 to refer to an environment variable named SDKROOT, you would need to use
 `${SDKROOT}` or `$SDKROOT`—but MacPorts doesn't set an environment
 variable called SDKROOT either. You could modify the port to do so.
 However:

 > Yet `libvpx` still builds (stock macports), the only time I see
 `-isysroot` being visible injected is when forcing an SDK version. (to
 enable +universal)

 When MacPorts wants a port to use an SDK, it already supplies the needed
 `-isysroot`/`-syslibroot` flags to do so in `CFLAGS`/`CXXFLAGS`/`LDFLAGS`.
 If the build system is already picking up those values, there's no need
 for the build system to manually add more SDK flags, so I would just
 remove any code it has that does that. (And if the build system is ''not''
 honoring the `CFLAGS`/`CXXFLAGS`/`LDFLAGS` MacPorts supplies, then
 ''that's'' what needs to be fixed.)

 *`$(SDKROOT)` ''is'' one of the two valid ways to refer to a ''Makefile''
 variable called SDKROOT (the other valid way being `${SDKROOT}`), but the
 configure.sh script is not a Makefile.

-- 
Ticket URL: <https://trac.macports.org/ticket/59360#comment:10>
MacPorts <https://www.macports.org/>
Ports system for macOS